WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #45537, comment 17


Ignore:
Timestamp:
05/18/2021 09:54:19 PM (6 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #45537, comment 17

    initial v1  
    22* It looks like unit tests currently fail due to an extra comma on line 2687 inside the `sprintf()` call. The PHP compatibility check displays a notice: "Trailing comma's are not allowed in function calls in PHP 7.2 or earlier".
    33* The function name should probably start with an underscore, for consistency with `_wp_posts_page_notice()`.
    4 * Instead of always hooking the function to `admin_notices` and then checking the post ID inside the function, let's perform that check in `wp-admin/edit-form-blocks.php`, for consistency with how it's done for the classic editor in `wp-admin/edit-form-advanced.php`.
     4* Instead of always hooking the function to `admin_notices` and then checking the post ID inside the function, let's perform that check in `wp-admin/edit-form-blocks.php`, for consistency with how it's done for the classic editor in [source:tags/5.7.2/src/wp-admin/edit-form-advanced.php?marks=81-84#L71 wp-admin/edit-form-advanced.php].