#45555 closed defect (bug) (wontfix)
Twenty Nineteen: Remove duplicate meta info on single post
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | 5.0 |
| Component: | Bundled Theme | Keywords: | has-patch needs-testing close 2nd-opinion |
| Focuses: | Cc: |
Attachments (2)
Change History (10)
#2
@
7 years ago
Thanks for this report, @pratikkry!
@allancole or @kjellr, can you confirm if this is displaying as intended?
#3
@
7 years ago
Can you confirm if this is displaying as intended?
It is, but I see how this is an issue with short posts. I'd be supportive of removing the author and date from the post footers, since it already exists in the header.
#6
@
2 years ago
- Keywords close 2nd-opinion added
Removing this meta information now, so long after release, would be an unexpected change for existing users of the theme.
Because of this, I recommend closing the ticket.
#7
@
2 years ago
- Milestone Future Release deleted
- Resolution set to wontfix
- Status changed from new to closed
I do not like the duplication, but I agree about closing the ticket. Some people may want to remove links from the header, others from the footer, and some people may like all the links where they are. The Core team probably should not make that decision for everyone using the theme.
I am not sure either if this is a desired behavior, but to me it is a welcome behavior, specially for long posts.
I would however like to suggest the following modification in
twentynineteen_entry_footerin/var/www/wp-projects/subratasarkar.com/wp-content/themes/twentynineteen/inc/template-tags.phpfile which will allow us to customize the behavior ofentry-footeras per our need.<?php if ( ! function_exists( 'twentynineteen_entry_footer' ) ) : /** * Prints HTML with meta information for the categories, tags and comments. */ function twentynineteen_entry_footer( $show_post_meta = true ) { if( ! $show_post_meta ) return; // Hide author, post date, category and tag text for pages. if ( 'post' === get_post_type() ) { // Posted by if( is_array( $show_post_meta ) && ! empty( $show_post_meta ) ) { if( true === $show_post_meta['show_author'] ) { twentynineteen_posted_by(); } } else { twentynineteen_posted_by(); } // Posted on if( is_array( $show_post_meta ) && ! empty( $show_post_meta ) ) { if( true === $show_post_meta['posted_on'] ) { twentynineteen_posted_on(); } } else { twentynineteen_posted_on(); } } } ... rest of the code remains intact ... endif;And this is how we can call it:
$post_meta_options = falsehides the entire entry footer whileadds the ability to render
AuthorandPosted Onas per requirement.