Opened 6 years ago
Closed 6 years ago
#45559 closed defect (bug) (duplicate)
W3C CSS Validator error in some core CSS files
Reported by: | man4toman | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-screenshots |
Focuses: | ui, coding-standards | Cc: |
Description
There is some error related to transition delay value. In some core CSS files the delay values sets on "0" and it's incorrect, it must be "0s".
The related patches is for these files:
wp-admin/css/common.css wp-admin/css/themes.css wp-includes/css/dashicons.css
Attachments (6)
Change History (18)
#1
@
6 years ago
Would you mind creating the patches from the root of your WordPress development directory so that patch files contain the full paths? Makes it easier to apply the changes locally :-)
#2
@
6 years ago
@swissspidy
Hmm, do I understand you? The new patch contain all files path.
#3
@
6 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 5.0.1
- Version 5.0 deleted
#4
follow-up:
↓ 5
@
6 years ago
@mukesh27 Thanks but I remember @netweb told me there isn't need to patch RTL codes because they use RTLCSS to generate RTL files, so I didn't add codes for RTL.
Then I think the first patch file is OK.
#5
in reply to:
↑ 4
;
follow-up:
↓ 7
@
6 years ago
Replying to man4toman:
@mukesh27 Thanks but I remember @netweb told me there isn't need to patch RTL codes because they use RTLCSS to generate RTL files, so I didn't add codes for RTL.
This is correct, the RTL CSS files are automatically generated by the build tools
Then I think the first patch file is OK.
#7
in reply to:
↑ 5
@
6 years ago
Thanks @netweb. i don't know how rtl css generate.
Replying to netweb:
Replying to man4toman:
@mukesh27 Thanks but I remember @netweb told me there isn't need to patch RTL codes because they use RTLCSS to generate RTL files, so I didn't add codes for RTL.
This is correct, the RTL CSS files are automatically generated by the build tools
Then I think the first patch file is OK.
common.css