WordPress.org

Make WordPress Core

#45564 closed defect (bug) (duplicate)

Database and Success Message

Reported by: daniyalahmedk Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.0
Component: Upgrade/Install Keywords: has-patch needs-refresh
Focuses: Cc:

Description

If there is an issue in database user access for example if database user isn't allowed to create tables and we trying to install WordPress it shows all the errors on the screen.

WordPress database error: [CREATE command denied to user ....

And if we scroll down at the bottom it shows success message which is totally incorrect, because WordPress isn't installed at all. I think there is some missing check here, that if the database got some error it should some message and prevent it from showing a success message.

Success!
WordPress has been installed. Thank you, and enjoy!

Thank you!

Attachments (2)

install.php.zip (5.4 KB) - added by daniyalahmedk 16 months ago.
install.patch (684 bytes) - added by daniyalahmedk 16 months ago.
Install Patch

Download all attachments as: .zip

Change History (5)

#1 @subrataemfluence
16 months ago

  • Keywords needs-refresh added

Thanks for the ticket!

Please upload a .diff or .patch file for review. This compares your new and old versions of the files and creates a new file with only the changes you made.

$ diff -u old-file new-file > filename.patch

https://www.shellhacks.com/create-patch-diff-command-linux/

@daniyalahmedk
16 months ago

Install Patch

#2 @subrataemfluence
16 months ago

I think patch should include file path in order to apply it.

The header of a patch file should look like this:

diff --git path/to/old-file.php path/to/new-file.php
index xxxxxxx..xxxxxxx 000000
--- path/to/old-file.php
+++ path/to/new-file.php
... your changes come here (includes both additions and deletions)

#3 @SergeyBiryukov
16 months ago

  • Component changed from General to Upgrade/Install
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Hi @daniyalahmedk, welcome to WordPress Trac!

Thanks for the report, we're already tracking this issue in #12671.

Note: See TracTickets for help on using tickets.