Make WordPress Core

Opened 8 years ago

Last modified 3 months ago

#45569 reviewing enhancement

@var array tag is not present in class WP_Upgrader_Skin

Reported by: utsav72640 Owned by: SergeyBiryukov
Priority: normal Milestone: Future Release
Component: Upgrade/Install Version: 5.0
Severity: minor Keywords: has-patch needs-refresh
Cc: Focuses: docs

Description

There is a class WP_Upgrader_Skin{} which is having line number 29 @var array $options but not in the comment.

Attachments (2)

class-wp-upgrader-skin.php.patch (416 bytes ) - added by utsav72640 8 years ago.
wp-admin\includes\class-wp-upgrader-skin.php
45569.patch (728 bytes ) - added by mukesh27 8 years ago.
Updated patch with remaining vars.

Download all attachments as: .zip

Change History (8)

@utsav72640
8 years ago

wp-admin\includes\class-wp-upgrader-skin.php

#1 @mukesh27
8 years ago

  • Component GeneralUpgrade/Install
  • Focuses docs added
  • Severity normalminor
  • Summary @var array tag is not present in class WP_Upgrader_Skin{}.@var array tag is not present in class WP_Upgrader_Skin

@mukesh27
8 years ago

Updated patch with remaining vars.

#2 @utsav72640
8 years ago

Thank You @mukesh27

This ticket was mentioned in Slack in #core by utsav72640. View the logs.


8 years ago

#4 @SergeyBiryukov
8 years ago

  • Milestone Awaiting Review5.1
  • Owner set to SergeyBiryukov
  • Status newreviewing

#5 @pento
8 years ago

  • Keywords needs-refresh added
  • Milestone 5.1Future Release

45569.patch needs some changes:

#6 @sainathpoojary
3 months ago

Looks like this has already been taken care of! All the missing docblocks for $upgrader, $done_header, $done_footer, $result, and $options in WP_Upgrader_Skin were added in 48661 as part of #42923. Can be closed as a duplicate.

Note: See TracTickets for help on using tickets.