WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #45615, comment 36


Ignore:
Timestamp:
01/04/2019 11:35:02 PM (10 months ago)
Author:
joemcgill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #45615, comment 36

    initial v1  
    22
    33The approach in [attachment:"45615.3.diff"] is ok for 5.0.3, and then we can follow with a broader refactor to make this less "hacky" as you put it. I don't think we should take this occasion to add support for .json files, even though the workaround for #45633 is mildly annoying for now. I've modified your approach slightly in that regard and to also add back support for `vtt` files when they're reported as `text/plain` by the server, which should fix #45622.
     4
     5I think we can take a similar approach to add support for other miscellaneous types that are commonly misidentified.