WordPress.org

Make WordPress Core

Opened 4 months ago

Last modified 7 weeks ago

#45634 new defect (bug)

Convert references to 'classic editor' and 'block editor' when referring to the interface and not the plugin

Reported by: garrett-eclipse Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.0
Component: Text Changes Keywords: has-patch 2nd-opinion
Focuses: docs, coding-standards Cc:

Description (last modified by garrett-eclipse)

Hello,

Just from a consistency standpoint was running through and found several lowercase instances of terms ('classic editor' and 'block editor') that should be proper nouns.

Instances of 'classic editor';
https://build.trac.wordpress.org/browser/branches/5.0/wp-admin/includes/post.php?marks=2227#L2227
https://build.trac.wordpress.org/browser/branches/5.0/wp-admin/includes/template.php?marks=1049#L1049

Instances of 'block editor';
https://build.trac.wordpress.org/browser/branches/5.0/wp-admin/includes/post.php?marks=2227#L2227
*Note: this is the same one mentioned in the 'classic editor' list above.

There may be some instances in other areas of the code (comments, readme, etc) as the above were taken from translation.wp.org so are i18n strings.

Cheers
P.S. I opened a similar ticket on Gutenberg and it's started a discussion about the convention so defer to that decision.
https://github.com/WordPress/gutenberg/pull/12856

Attachments (3)

45634.patch (1.8 KB) - added by faisal03 4 months ago.
45634-Block-Editor.patch (8.0 KB) - added by faisal03 4 months ago.
45634.diff (4.4 KB) - added by garrett-eclipse 7 weeks ago.
Converting 'Block Editor' and 'Classic Editor', where not in reference to the plugin, to lowercase.

Download all attachments as: .zip

Change History (13)

#1 @garrett-eclipse
4 months ago

  • Description modified (diff)

#2 @garrett-eclipse
4 months ago

  • Description modified (diff)

#3 @garrett-eclipse
4 months ago

  • Description modified (diff)

This ticket was mentioned in Slack in #core by subratasarkar. View the logs.


4 months ago

@faisal03
4 months ago

#5 @mukesh27
4 months ago

#45639 was marked as a duplicate.

#6 @swissspidy
4 months ago

At the moment, Twenty Nineteen is still being developed on GitHub. This will change soon, but for now please submit changes to the theme as pull requests at https://github.com/WordPress/twentynineteen

By the way, if we decide to make this change, it sounds like a good addition for https://make.wordpress.org/core/handbook/best-practices/spelling/

#7 @faisal03
4 months ago

  • Focuses docs coding-standards added
  • Keywords has-patch added

@swissspidy Thanks for the suggestions. I have created a PR there https://github.com/WordPress/twentynineteen/pull/740

But in this ticket's patch, there are changes out of Twenty Nineteen, which should be approved.

Last edited 4 months ago by faisal03 (previous) (diff)

#8 @SergeyBiryukov
3 months ago

  • Keywords close added

Per https://make.wordpress.org/core/handbook/best-practices/spelling/, “block editor” or “block-based editor” should be used instead of “Block Editor” or “Gutenberg”.

#9 @kjellr
3 months ago

At the moment, Twenty Nineteen is still being developed on GitHub. This will change soon, but for now please submit changes to the theme as pull requests at https://github.com/WordPress/twentynineteen

@swissspidy Thanks for the suggestions. I have created a PR there https://github.com/WordPress/twentynineteen/pull/740

But in this ticket's patch, there are changes out of Twenty Nineteen, which should be approved.

Just noting that we're migrating Twenty Nineteen changes to Trac now, so I've closed that issue on GitHub in favor of this one.

The Twenty Nineteen changes in 45634.patch look good on my end, but I agree with @SergeyBiryukov that the references to "Block Editor" in 45634-Block-Editor.patch should be "block editor" or "block-based editor" instead.

Thanks!

@garrett-eclipse
7 weeks ago

Converting 'Block Editor' and 'Classic Editor', where not in reference to the plugin, to lowercase.

#10 @garrett-eclipse
7 weeks ago

  • Keywords 2nd-opinion added; close removed
  • Summary changed from Convert references to 'classic editor' and 'block editor' to proper nouns to Convert references to 'classic editor' and 'block editor' when referring to the interface and not the plugin

Hello,

I've uploaded a patch to address the 'Classic Editor' and 'Block Editor' instances that referred to the interfaces to lowercase. This follows the coding standards for spelling.

Updated the ticket title to reflect this.

Cheers

Note: See TracTickets for help on using tickets.