Convert references to 'classic editor' and 'block editor' when referring to the interface and not the plugin

[garrett-eclipse]

Hello,

Just from a consistency standpoint was running through and found several lowercase instances of terms ('classic editor' and 'block editor') that should be proper nouns.

Instances of 'classic editor';
​https://build.trac.wordpress.org/browser/branches/5.0/wp-admin/includes/post.php?marks=2227#L2227
​https://build.trac.wordpress.org/browser/branches/5.0/wp-admin/includes/template.php?marks=1049#L1049

Instances of 'block editor';
​https://build.trac.wordpress.org/browser/branches/5.0/wp-admin/includes/post.php?marks=2227#L2227
*Note: this is the same one mentioned in the 'classic editor' list above.

There may be some instances in other areas of the code (comments, readme, etc) as the above were taken from translation.wp.org so are i18n strings.

Cheers
P.S. I opened a similar ticket on Gutenberg and it's started a discussion about the convention so defer to that decision.
​https://github.com/WordPress/gutenberg/pull/12856

[mukesh27]

#45639 was marked as a duplicate.

[swissspidy]

At the moment, Twenty Nineteen is still being developed on GitHub. This will change soon, but for now please submit changes to the theme as pull requests at ​https://github.com/WordPress/twentynineteen

By the way, if we decide to make this change, it sounds like a good addition for ​https://make.wordpress.org/core/handbook/best-practices/spelling/

[faisal03]

@swissspidy Thanks for the suggestions. I have created a PR there ​https://github.com/WordPress/twentynineteen/pull/740

But in this ticket's patch, there are changes out of Twenty Nineteen, which should be approved.

[SergeyBiryukov]

Per ​https://make.wordpress.org/core/handbook/best-practices/spelling/, “block editor” or “block-based editor” should be used instead of “Block Editor” or “Gutenberg”.

[kjellr]

At the moment, Twenty Nineteen is still being developed on GitHub. This will change soon, but for now please submit changes to the theme as pull requests at ​https://github.com/WordPress/twentynineteen

@swissspidy Thanks for the suggestions. I have created a PR there ​https://github.com/WordPress/twentynineteen/pull/740

But in this ticket's patch, there are changes out of Twenty Nineteen, which should be approved.

Just noting that we're migrating Twenty Nineteen changes to Trac now, so I've closed that issue on GitHub in favor of this one.

The Twenty Nineteen changes in 45634.patch look good on my end, but I agree with @SergeyBiryukov that the references to "Block Editor" in 45634-Block-Editor.patch should be "block editor" or "block-based editor" instead.

Thanks!

[garrett-eclipse]

Converting 'Block Editor' and 'Classic Editor', where not in reference to the plugin, to lowercase.

[garrett-eclipse]

Hello,

I've uploaded a patch to address the 'Classic Editor' and 'Block Editor' instances that referred to the interfaces to lowercase. This follows the coding standards for spelling.

Updated the ticket title to reflect this.

Cheers

[garrett-eclipse]

Refreshed so it applies cleanly

[garrett-eclipse]

I've refreshed this for trunk in 45634.2.diff as well as handle one case of Classic block as the convention is to lowercase the 'block' portion of block names.
Reference - ​https://github.com/WordPress/gutenberg/issues/16118#issuecomment-501458511

Slating for 5.3 as it's an easy fix

[garrett-eclipse]

Refresh, no code change, just addressing hunk offset.

[garrett-eclipse]

This still applies cleanly and passes unit tests. I just refreshed in 45634.3.diff to address the hunk offset on trunk.

Moving into commit for final review, @SergeyBiryukov do you have time to look at this in 5.3?

[ocean90]

In 46386:

Docs: Convert 'Block Editor' to lowercase.

Props garrett-eclipse.
Fixes #45634.