get_blogs_of_user improvements

[maniu]

get_blogs_of_user function is often pulling more data than it needs. This often won't cause any issues but in some cases when user is attached to big number of blogs, it may lead to out of memory error.

Attached patch has changes that can lead to more improvements like pagination for "My Sites" admin page, limitation of listed sites in admin bar and on "access denied" page.

[maniu]

get_blogs_of_user improvements

[earnjam]

Hi @maniu, thanks for your ticket! There are definitely improvements to be made around querying sites across a network and improvements to get_blogs_of_user() are likely part of the overall ​multisite roadmap.

We'll probably pick up more of those discussions as we resume our weekly meetings in Slack in the new year and post 5.0.

Regarding the specific patch here, I wonder if it might make more sense to keep the second parameter as the current boolean value, and instead checking for some type of all_ids value in the $args array.

Mixing the type (bool, string) and usage (manipulating the returned list of sites vs returned fields) of a single parameter feels like it could easily lead to confusion.

[maniu]

Hey @earnjam, yeah I think you are right. I could have avoided all_ids as having $all = true together with $args = array( 'fields' => 'ids' ) can cover it. I will work on another patch. Thanks!

[maniu]

modified version that does not include tweaks to $all parameters as they are confusing and not crucial for performance improvement.

[alexstine]

At this point, this one probably badly needs a refreshed patch.

@maniu, is this still a problem?

[maniu]

@alexstine Sorry for late response! I believe it is still a problem and now I have also realized that there is potential to improve get_active_blog_for_user performance as well. I will submit updated diff or pull request once its ready. Thanks:)!