function is_child_theme() bug

[samet5]

<?php
function is_child_theme() {
        return ( TEMPLATEPATH !== STYLESHEETPATH );
}

needs to get replaced in:

<?php
function is_child_theme() {
        return ( 'TEMPLATEPATH' !== 'STYLESHEETPATH' );
}

[samet5]

/wp-includes/theme.php

[swissspidy]

Hi, and welcome to WordPress Trac!

Why do you think this needs to be changed?

TEMPLATEPATH !== STYLESHEETPATH compares the two constants TEMPLATEPATH and STYLESHEETPATH, which can have any value.

On the other hand, 'TEMPLATEPATH' !== 'STYLESHEETPATH' compares the two strings "TEMPLATEPATH" and "STYLESHEETPATH", which will never be the same.

[samet5]

I think this will not work in newer php versions

[SergeyBiryukov]

Comparing constants should work in any PHP version, I don't see an issue here.