Retire wp-tinymce.php

[azaozz]

The method of loading TinyMCE was added many years ago. All TinyMCE scripts are concatenated and pre-compressed, then we point the script tag src to wp-tinymce.php where we determine if the browser supports compression, add the appropriate headers and output the actual wp-tinymce.js.gz.

This, indeed, is the fastest way to load a lot of JS without relying on the server to compress it. However lately been seeing more and more reports of that file being blocked by some security measures. Also, nearly all servers compress .js and .css files now.

[azaozz]

Thinking we can still concatenate all of TinyMCE's scripts when building, but not compress them so we don't depend on specific headers that need to be set in PHP. Will also need to keep wp-tinymce.php for a while in case something is accessing it directly (can try adding some form of "doing-it-wrong" there too). It will output the non-compressed wp-tinymce.js too.

[azaozz]

In 45645.diff:

• Remove compression of wp-tinymce.js at build time from Gruntfile.js.
• Remove the grunt-contrib-compress dependency.
• Edit and keep wp-tinymce.php for back-compat in case "something" is accessing it directly.

Note that package-lock.json was generated on Windows and seems to have a lot of red.

[pento]

Should add a _deprecated_file() call in wp-tinymce.php, too.

Otherwise, I'm fine with this going in if you can shepherd it, @azaozz.

[azaozz]

Replying to pento:

Should add a _deprecated_file() call in wp-tinymce.php, too.

Yeah, was thinking about adding something like it but wp-tinymce.php outputs (previously compressed) js, shouldn't have any other output or it will break it.

Thinking package-lock.json may need another look/redoing on non-Windows to keep it compatible. Will try to review and commit today.

[azaozz]

In 44651:

TinyMCE: retire wp-tinymce.php and remove pre-compression of wp-tinymce.js.

Fixes #45645.

[ocean90]

wp-tinymce.js needs to be removed from $_old_files. At the same time wp-tinymce.js.gz should be added.

[garrett-eclipse]

Updated $_old_files to remove wp-tinymce.js and add wp-tinymce.js.gz

[garrett-eclipse]

@azaozz the build issue appears to be caused by this ​line which lists the new build location for wp-tinymce.js in the $_old_files array found in update-core.php as @ocean90 mentioned.

I've uploaded a patch with the changes mentioned and reference this ticket in the inline comment.

[azaozz]

In 44654:

TinyMCE: fix $_old_files after [44651], remove wp-tinymce.js and add wp-tinymce.js.gz.

Props ocean90, garrett-eclipse.
Fixes #45645.