WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 2 months ago

#45679 closed defect (bug) (fixed)

Bundled Themes: Bump script and style version numbers

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-testing commit fixed-major
Focuses: Cc:

Description (last modified by laurelfulford)

When existing scripts or styles are updated in default themes, the version numbers in the enqueues should also be bumped to make sure the old files don't cache.

This was missed in a Twenty Sixteen update in 5.0, as well as some upcoming updates slated for 5.0.2. Specifically:

Twenty Seventeen

Twenty Sixteen

Twenty Fifteen

Twenty Fourteen

Twenty Thirteen

  • blocks.css & editor-blocks.css (#45431)

Twenty Twelve

Twenty Eleven

(Thanks to @SergeyBiryukov for catching this here!)

Attachments (2)

45679.patch (9.9 KB) - added by laurelfulford 3 months ago.
45679.2.patch (12.6 KB) - added by laurelfulford 3 months ago.

Download all attachments as: .zip

Change History (12)

#1 @laurelfulford
3 months ago

  • Milestone changed from Awaiting Review to 5.0.3

Setting for 5.0.3 since 5.0.2 is already in RC; the above will need to be rechecked and updated with any other updates that go into 5.0.3.

#2 @laurelfulford
3 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

45679.patch takes care of the updates above, and also bumps the versions the following files since they will be updated when #45541 is committed:

  • editor-blocks.css in Twenty Fourteen
  • editor-blocks.css in Twenty Fifteen
  • editor-blocks.css in Twenty Sixteen

#3 @laurelfulford
3 months ago

Since release, Twenty Nineteen has also had updates to the following files that can have their versions bumped, to make sure they're not cached:

  • priority-menu.js
  • touch-keyboard-navigation.js
  • style-editor-customizer.css
  • customize-preview.js
  • customize-controls.js

#4 follow-up: @laurelfulford
3 months ago

45679.2.patch is an update of the original patch to include Twenty Nineteen.

#5 in reply to: ↑ 4 @netweb
3 months ago

  • Keywords commit added

Replying to laurelfulford:

45679.2.patch is an update of the original patch to include Twenty Nineteen.

Looks good to me

#6 @laurelfulford
3 months ago

  • Description modified (diff)

Thank you for the review, @netweb!

I belatedly realized that this is the only update currently slated for Twenty Ten for 5.0.3, and it's quite minor for a whole new version of a theme. The CSS change the version bump is meant to cover is also pretty small (#45434).

I'm going to skip committing that theme's functions.php for now, and handle it in a future release of Twenty Ten where there are more changes.

I've updated the ticket description above to remove it from the list.

#7 @laurelfulford
3 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44382:

Bundled Themes: Bump script and style version numbers.

When existing scripts or styles are updated in default themes, the version numbers in the enqueues should also be bumped to make sure the old files don't cache. This update bumps version numbers for changes since version 5.0, for themes Twenty Eleven through Twenty Nineteen.

Fixes #45679.

#8 @SergeyBiryukov
2 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merging to the 5.0 branch.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


2 months ago

#10 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44434:

Bundled Themes: Bump script and style version numbers.

When existing scripts or styles are updated in default themes, the version numbers in the enqueues should also be bumped to make sure the old files don't cache. This update bumps version numbers for changes since version 5.0, for themes Twenty Eleven through Twenty Nineteen.

Props laurelfulford.
Merges [44382] to the 5.0 branch.
Fixes #45679.

Note: See TracTickets for help on using tickets.