WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#45689 closed defect (bug) (fixed)

Twenty Nineteen: Incorrect opacity and text shadow on submenus when there's a featured image.

Reported by: kjellr Owned by: laurelfulford
Milestone: 5.0.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch fixed-major
Focuses: Cc:

Description

On pages that have a featured image, submenu item labels are incorrectly inheriting some styles from the top-level menu text:

  • The text have a small text-shadow
  • The menu items are at 0.6 opacity on hover

This hurts readability, and results in the menu items appearing different from their counterparts on pages with no featured image.

https://cldup.com/kpZmnkUcrj.png

The patch attached restores the expected styles:

https://cldup.com/RKFUmxjdnH.thumb.jpg

(Ported from https://github.com/WordPress/twentynineteen/pull/730 in the Twenty Nineteen GitHub repository)

Attachments (2)

45689.patch (2.5 KB) - added by kjellr 5 months ago.
45689.2.patch (2.5 KB) - added by kjellr 5 months ago.
Corrected patch to run from the src directory.

Download all attachments as: .zip

Change History (7)

@kjellr
5 months ago

@kjellr
5 months ago

Corrected patch to run from the src directory.

#1 @laurelfulford
5 months ago

  • Milestone changed from Awaiting Review to 5.0.3
  • Owner set to laurelfulford
  • Status changed from new to assigned

#2 @laurelfulford
5 months ago

Thanks @kjellr -- this looks good to me! I'll commit, and add a comment to the related GitHub PR to close the loop.

#3 @laurelfulford
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44368:

Twenty Nineteen: Remove transparency from submenus.

On pages and posts with featured images, the top level menu items have a slight transparency on hover, which was being inherited by their submenus. This update removes that inheritance, improving readability and consistency in the menu's appearance.

Props kjellr.
Fixes #45689.

#4 @SergeyBiryukov
5 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merging to the 5.0 branch.

#5 @SergeyBiryukov
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44427:

Twenty Nineteen: Remove transparency from submenus.

On pages and posts with featured images, the top level menu items have a slight transparency on hover, which was being inherited by their submenus. This update removes that inheritance, improving readability and consistency in the menu's appearance.

Props kjellr.
Merges [44368] to the 5.0 branch.
Fixes #45689.

Note: See TracTickets for help on using tickets.