Opened 2 years ago
Closed 2 years ago
#45700 closed defect (bug) (invalid)
Twenty Seventeen: Remove unused third-party resources from README.txt
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | Bundled Theme | Keywords: | has-patch |
| Focuses: | Cc: |
Description
In Twenty Seventeen theme README.txt file it shows Font Awesome icons and jQuery scrollTo third-party resources but it will not used in theme so needs to remove reference from third-party resources.
Attachments (1)
Change History (2)
#1
@
2 years ago
- Milestone Awaiting Review deleted
- Resolution set to invalid
- Status changed from new to closed
Thanks for the report and patch @mukesh27!
I took a look, and as far as I can tell both of these resources are still being used in the theme.
Even though the font itself isn't used, the SVG icons in Twenty Seventeen come from Font Awesome -- there's some discussion around that here:
https://github.com/WordPress/twentyseventeen/issues/60
ScrollTo also still looks like it's being used -- it's enqueued in functions.php, and the function scrollTo() shows up in both global.js and customize-preview.js.
I'm going to close this issue, but please let me know if you have any questions! Also thank you for raising this. It's always good to make sure the readme matches what's in the theme, and in this case it wasn't super-clear -- I had to do some digging to actually make sure these were both being used!
Patch.