WordPress.org
Get WordPress

Make WordPress Core

Opened 19 years ago

Closed 19 years ago

#4571 closed defect (bug) (fixed)

broken option values after saving

Reported by: m0n5t3r Owned by: markjaquith
Priority: high Milestone: 2.3
Component: Administration Version: 2.3
Severity: major Keywords: has-patch
Cc: Focuses:

Description

options.php calls trim and stripslashes on option values submitted from options pages.

When one of the values is an array, this breaks it and update_option saves the string "Array" in the database, which is, most of the times, not what the (plugin) options page author intended.

Attachments (2)

fix_option_parsing.diff​ (2.1 KB ) - added by m0n5t3r 19 years ago.
patch to address the issue
4571.diff​ (517 bytes ) - added by Nazgul 19 years ago.

Download all attachments as: .zip

Change History (5)

@m0n5t3r
19 years ago

patch to address the issue

#1 @markjaquith
19 years ago

  • Keywords needs-patch added; has-patch needs-testing 2nd-opinion removed
  • Owner changed from anonymous to markjaquith
  • Status new → assigned
  • Version → 2.3

see stripslashes_deep() We don't need to be trimming within the array.

@Nazgul
19 years ago

#2 @Nazgul
19 years ago

  • Keywords has-patch added; needs-patch removed

New patch attached.

#3 @ryan
19 years ago

  • Resolution → fixed
  • Status assigned → closed

(In [5886]) Don't trim option arrays on save. Props m0n5t3r, Nazgul. fixes #4571

Note: See TracTickets for help on using tickets.