Twenty Nineteen: Improve menu semantics and keyboard navigation.

[kjellr]

The Twenty Nineteen menu has a couple minor semantic issues:

• The ellipsis (...) button is currently rendered as a span instead of a button (originally reported in ​https://github.com/WordPress/twentynineteen/issues/723)
• The back button in the touch navigation is also rendered as a span instead of a button (originally reported in ​https://github.com/WordPress/twentynineteen/issues/714 )

The patch attached to this ticket takes care of those issues, and also removes an unnecessary tabindex="0" applied to the main-navigation element.

---

This patch ports over @allancole's changes from ​https://github.com/WordPress/twentynineteen/pull/735

Please note, it does not include that PRs fix for the problematic touchstart link behaviour in that original PR, as that's handled separately in #45510.

props: allancole, anevins

[laurelfulford]

Thanks for porting this over, @kjellr!

I've tested this and it looks like it's working correctly for me. The only issue I spotted is that, in style.css, the version got changed from 1.1 back to 1.0 (since it's not up-to-date in GitHub).

@kjellr are you available in the next day or so to refresh?

[laurelfulford]

Removing needs-refresh -- I double-checked, and can take care of fixing the version before committing :)

[laurelfulford]

In 44376:

Twenty Nineteen: Improve menu semantics and keyboard navigation.

The menu's original markup included some non-semantic tags and an unnecessary tabindex attribute that made it difficult to navigate via keyboard.

Props allancole, anevins, kjellr.
Fixes #45713.

[laurelfulford]

To close the loop, I added a comment to the related GitHub PR that this has been committed.

[SergeyBiryukov]

Reopening for merging to the 5.0 branch.

[SergeyBiryukov]

In 44426:

Twenty Nineteen: Improve menu semantics and keyboard navigation.

The menu's original markup included some non-semantic tags and an unnecessary tabindex attribute that made it difficult to navigate via keyboard.

Props allancole, anevins, kjellr.
Merges [44376] to the 5.0 branch.
Fixes #45713.