WordPress.org

Make WordPress Core

Opened 4 weeks ago

Closed 10 days ago

#45713 closed defect (bug) (fixed)

Twenty Nineteen: Improve menu semantics and keyboard navigation.

Reported by: kjellr Owned by: laurelfulford
Milestone: 5.0.3 Priority: normal
Severity: normal Version: 5.0.1
Component: Bundled Theme Keywords: has-patch fixed-major
Focuses: Cc:

Description

The Twenty Nineteen menu has a couple minor semantic issues:

The patch attached to this ticket takes care of those issues, and also removes an unnecessary tabindex="0" applied to the main-navigation element.

---

This patch ports over @allancole's changes from https://github.com/WordPress/twentynineteen/pull/735

Please note, it does not include that PRs fix for the problematic touchstart link behaviour in that original PR, as that's handled separately in #45510.

props: allancole, anevins

Attachments (1)

45713.patch (9.4 KB) - added by kjellr 4 weeks ago.

Download all attachments as: .zip

Change History (8)

@kjellr
4 weeks ago

#1 @laurelfulford
4 weeks ago

  • Milestone changed from Awaiting Review to 5.0.3
  • Owner set to laurelfulford
  • Status changed from new to assigned

#2 @laurelfulford
3 weeks ago

  • Keywords needs-refresh added

Thanks for porting this over, @kjellr!

I've tested this and it looks like it's working correctly for me. The only issue I spotted is that, in style.css, the version got changed from 1.1 back to 1.0 (since it's not up-to-date in GitHub).

@kjellr are you available in the next day or so to refresh?

#3 @laurelfulford
2 weeks ago

  • Keywords needs-refresh removed

Removing needs-refresh -- I double-checked, and can take care of fixing the version before committing :)

#4 @laurelfulford
2 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44376:

Twenty Nineteen: Improve menu semantics and keyboard navigation.

The menu's original markup included some non-semantic tags and an unnecessary tabindex attribute that made it difficult to navigate via keyboard.

Props allancole, anevins, kjellr.
Fixes #45713.

#5 @laurelfulford
2 weeks ago

To close the loop, I added a comment to the related GitHub PR that this has been committed.

#6 @SergeyBiryukov
10 days ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merging to the 5.0 branch.

#7 @SergeyBiryukov
10 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44426:

Twenty Nineteen: Improve menu semantics and keyboard navigation.

The menu's original markup included some non-semantic tags and an unnecessary tabindex attribute that made it difficult to navigate via keyboard.

Props allancole, anevins, kjellr.
Merges [44376] to the 5.0 branch.
Fixes #45713.

Note: See TracTickets for help on using tickets.