Opened 6 years ago
Closed 6 years ago
#45713 closed defect (bug) (fixed)
Twenty Nineteen: Improve menu semantics and keyboard navigation.
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.0.3 | Priority: | normal |
| Severity: | normal | Version: | 5.0.1 |
| Component: | Bundled Theme | Keywords: | has-patch fixed-major |
| Focuses: | Cc: |
Description
The Twenty Nineteen menu has a couple minor semantic issues:
- The ellipsis (...) button is currently rendered as a
spaninstead of abutton(originally reported in https://github.com/WordPress/twentynineteen/issues/723) - The back button in the touch navigation is also rendered as a
spaninstead of abutton(originally reported in https://github.com/WordPress/twentynineteen/issues/714 )
The patch attached to this ticket takes care of those issues, and also removes an unnecessary tabindex="0" applied to the main-navigation element.
---
This patch ports over @allancole's changes from https://github.com/WordPress/twentynineteen/pull/735
Please note, it does not include that PRs fix for the problematic touchstart link behaviour in that original PR, as that's handled separately in #45510.
props: allancole, anevins
Attachments (1)
Change History (8)
#1
@
6 years ago
- Milestone changed from Awaiting Review to 5.0.3
- Owner set to laurelfulford
- Status changed from new to assigned
#3
@
6 years ago
- Keywords needs-refresh removed
Removing needs-refresh -- I double-checked, and can take care of fixing the version before committing :)
#5
@
6 years ago
To close the loop, I added a comment to the related GitHub PR that this has been committed.
Note: See
TracTickets for help on using
tickets.
Thanks for porting this over, @kjellr!
I've tested this and it looks like it's working correctly for me. The only issue I spotted is that, in style.css, the version got changed from
1.1back to1.0(since it's not up-to-date in GitHub).@kjellr are you available in the next day or so to refresh?