WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45715 closed defect (bug) (fixed)

Twenty Nineteen: Remove underline from the arrow that follows "Continue reading" links

Reported by: kjellr's profile kjellr Owned by: laurelfulford's profile laurelfulford
Milestone: 5.0.3 Priority: normal
Severity: normal Version: 5.0.1
Component: Bundled Theme Keywords: has-patch fixed-major
Focuses: Cc:

Description

As noted in ​https://github.com/WordPress/twentynineteen/issues/698 :

The link with the default text "Continue reading" appears on the post list page when a Read more block is inserted in a post. The link is underlined and has an arrow behind it which is also underlined.

Since the arrow is used as iconography and not text, it should not be underlined. The attached patch makes that change by changing it from inline to inline-block.

Before:

https://cldup.com/YawEk4L_v4-3000x3000.png

After:

https://cldup.com/R1KXA3hSrV-3000x3000.png

---

This patch ports over @littlebigthing's changes from ​https://github.com/WordPress/twentynineteen/pull/699

props: littlebigthing

Attachments (1)

45715.patch​ (1.2 KB) - added by kjellr 6 years ago.

Download all attachments as: .zip

Change History (7)

@kjellr
6 years ago

#1 @laurelfulford
6 years ago

  • Milestone changed from Awaiting Review to 5.0.3
  • Owner set to laurelfulford
  • Status changed from new to assigned

#2 @laurelfulford
6 years ago

Thanks for porting this over, @kjellr! The update looks good -- I'll commit, and follow up on the GitHub PR to close the loop.

#3 @laurelfulford
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44369:

Twenty Nineteen: Remove underline from "Continue Reading" arrow.

The "Continue Reading" link that's generated by the More block is styled to include an arrow next to the text; that arrow shouldn't inherit the text underline style. This update removes it.

Props littlebigthing, kjellr.
Fixes #45715.

#4 @LittleBigThing
6 years ago

Great, thanks @laurelfulford and @kjellr!

#5 @SergeyBiryukov
6 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merging to the 5.0 branch.

#6 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44422:

Twenty Nineteen: Remove underline from "Continue Reading" arrow.

The "Continue Reading" link that's generated by the More block is styled to include an arrow next to the text; that arrow shouldn't inherit the text underline style. This update removes it.

Props littlebigthing, kjellr.
Merges [44369] to the 5.0 branch.
Fixes #45715.

Note: See TracTickets for help on using tickets.