WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#45716 closed defect (bug) (fixed)

Twenty Nineteen: Push right-aligned images outside of the text column on the front end

Reported by: kjellr Owned by: laurelfulford
Milestone: 5.0.3 Priority: normal
Severity: normal Version: 5.0.1
Component: Bundled Theme Keywords: has-patch fixed-major
Focuses: Cc:

Description

Right-aligned images in Twenty Nineteen are intended to float outside of the text column in both the front and back end. Currently, this works in the editor, but not on the front end.

The attached patch sets the max-width for wp-block-image to 100%, allowing us push right-floated images outside the content area. It also includes style adjustments to center-aligned images to preserve their behavior alongside that change.

Before:

https://cldup.com/U04bNS__he-3000x3000.png

After:

https://cldup.com/aGQ7bzMwhM-3000x3000.png

---

This issue was originally reported in https://github.com/WordPress/twentynineteen/issues/696
This patch ports over changes from https://github.com/WordPress/twentynineteen/pull/702

props: kjellr, joen, allancole

Attachments (2)

45716.patch (4.3 KB) - added by kjellr 5 months ago.
45716.2.patch (4.3 KB) - added by kjellr 5 months ago.
Re-compiling the CSS to eliminate differences between style.css and style-rtl.css.

Download all attachments as: .zip

Change History (6)

@kjellr
5 months ago

@kjellr
5 months ago

Re-compiling the CSS to eliminate differences between style.css and style-rtl.css.

#1 @laurelfulford
5 months ago

  • Milestone changed from Awaiting Review to 5.0.3
  • Owner set to laurelfulford
  • Status changed from new to assigned

#2 @laurelfulford
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44371:

Twenty Nineteen: Push right-aligned image block outside of text column.

Update right-aligned image block styles to push them outside of the text column on the front end, to match the original design and how the block looks in the editor.

Props kjellr, joen, allancole.
Fixes #45716.

#3 @SergeyBiryukov
5 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merging to the 5.0 branch.

#4 @SergeyBiryukov
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44428:

Twenty Nineteen: Push right-aligned image block outside of text column.

Update right-aligned image block styles to push them outside of the text column on the front end, to match the original design and how the block looks in the editor.

Props kjellr, joen, allancole.
Merges [44371] to the 5.0 branch.
Fixes #45716.

Note: See TracTickets for help on using tickets.