WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45726 closed defect (bug) (fixed)

Twenty Nineteen: By default, the hover on outlined buttons is white text on a white background

Reported by: kjellr's profile kjellr Owned by: laurelfulford's profile laurelfulford
Milestone: 5.0.3 Priority: normal
Severity: normal Version: 5.0.2
Component: Bundled Theme Keywords: has-patch fixed-major
Focuses: Cc:

Description

Currently in Twenty Nineteen, if you choose the "Outlined" style for a button block, the hover state on the front end displays white text on a white background:

https://cldup.com/qfqPmK5gvp-1200x1200.png

This is clearly not readable. The attached patch sets the text color to black by default, to match the outline color:

https://cldup.com/plK_Fo9gPT-1200x1200.png

---

This patch ports over @rickalee's changes from ​https://github.com/WordPress/twentynineteen/pull/703

props: rickalee

Attachments (1)

45726.patch​ (1.7 KB) - added by kjellr 6 years ago.

Download all attachments as: .zip

Change History (6)

@kjellr
6 years ago

#1 @laurelfulford
6 years ago

  • Milestone changed from Awaiting Review to 5.0.3
  • Owner set to laurelfulford
  • Status changed from new to assigned

#2 @laurelfulford
6 years ago

Thanks for porting this over, @kjellr! The fix looks good -- I'll commit, then follow up in the PR to close loops.

#3 @laurelfulford
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44370:

Twenty Nineteen: Fix hover appearance for outlined button block style.

The outlined button block style was displaying white text on a white background on hover. This update makes sure the text remains legible on hover when this button style is applied.

Props rickalee, kjellr.
Fixes #45726.

#4 @SergeyBiryukov
6 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merging to the 5.0 branch.

#5 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44424:

Twenty Nineteen: Fix hover appearance for outlined button block style.

The outlined button block style was displaying white text on a white background on hover. This update makes sure the text remains legible on hover when this button style is applied.

Props rickalee, kjellr.
Merges [44370] to the 5.0 branch.
Fixes #45726.

Note: See TracTickets for help on using tickets.