wp_new_user_notification should use get_password_reset_key

[spacedmonkey]

Since the function get_password_reset_key was introducted in [34923] it means, there is now repeated logic in the function wp_new_user_notification has repeated logic. This should be replaced.

[spacedmonkey]

CCing @mikeschroder for background on this one.

[mrasharirfan]

I have replaced the repeated logic in wp_new_user_notification for password reset key with get_password_reset_key function.

[spacedmonkey]

Thanks for @mrasharirfan the first patch.

The only thing I would change, is add a little error handling. get_password_reset_key can return a WP_Error. So there should be the following check added.

if ( is_wp_error( $key ) ) {
    return;
}

[mrasharirfan]

@spacedmonkey you're right. Thanks for the tip 💯

The only thing I would change, is add a little error handling. get_password_reset_key can return a WP_Error. So there should be the following check added.

if ( is_wp_error( $key ) ) {
    return;
}

[mrasharirfan]

Added error handling for WP_Error class

[desrosj]

45745.1.diff​ needs to be refreshed against trunk.

Assigning to mark good first bug claimed.

[SergeyBiryukov]

In 45712:

Users: Use get_password_reset_key() in wp_new_user_notification().

Props mrasharirfan, spacedmonkey.
Fixes #45745.