get_password_reset_key should use wp_update_user

[spacedmonkey]

In the function, get_password_reset_key, the user record is updated, however this function call doesn't use wp_update_user (wp_insert_user), none of the actions or filters are run. Worse yet, the clean_user_cache function and actions are not called.

[spacedmonkey]

Related: #45745

[spacedmonkey]

Thanks @jayswadas for the patch.

Looking at the patch, there a couple of issues, I had with it. I would change it the following

$key_saved = wp_update_user( array( 'ID' => $user->ID, 'user_activation_key' => $hashed, 'user_login' => $user->user_login ) );
if ( is_wp_error( $key_saved ) ) {
   return $key_saved;
}

Couple of differences.

1. Removed clean_user_cache call, as this is already classed in wp_update_user
2. Check the value $key_saved and return. As wp_update_user doesn't allows successfully.

If you can update the patch @jayswadas and run the phpunit tests, we could nearly be there.

[donmhico]

@spacedmonkey I applied the latest patch submitted by @jayswadas (45746-2.diff) and run the phpunit tests.

This is the phpunit output.

OK, but incomplete, skipped, or risky tests!
Tests: 9634, Assertions: 73861, Skipped: 39.

I'm not entirely sure if this is good enough because of the skipped tests.

[garrett-eclipse]

Hi @donmhico if there are no failing tests then you should be good to go. A skipped test occurs when your environment doesn't support the test those are usually tests for specific database drivers or other environment-specific tests.

[SergeyBiryukov]

In 45713:

Users: Reorganize user_nicename, user_url, user_registered setting in wp_insert_user() for consistency with the order or fields in the database.

See #45746.

[SergeyBiryukov]

In 45714:

Users: Use wp_update_user() in get_password_reset_key().

Props jayswadas, spacedmonkey, donmhico, SergeyBiryukov.
Fixes #45746.