WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #4575, comment 30


Ignore:
Timestamp:
06/15/2015 09:23:15 PM (6 years ago)
Author:
stevenkword
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4575, comment 30

    v1 v2  
    1212>  * What's the purpose of get_lastcommentmodified()? Assuming the atom feed is also updated, it won't be used anymore. Seems like we might need to do some tweaks.
    1313
    14 I did a little digging through the plugin repo and found that [https://raw.githubusercontent.com/stevenkword/WordPress-Plugin-Directory-Slurper/master/get_lastcommentmodified.txt: 6 plugins] are using `get_lastcommentmodified` and roughly [https://raw.githubusercontent.com/stevenkword/WordPress-Plugin-Directory-Slurper/master/get_lastpostmodified.txt: 100 plugins] are making calls to `get_lastpostmodified`. Looking at some of those plugin names, I am not sure we should deprecate the functions since the expected behavior might be slightly different.
     14I did a little digging through the plugin repo and found that [https://raw.githubusercontent.com/stevenkword/WordPress-Plugin-Directory-Slurper/master/get_lastcommentmodified.txt 6 plugins] are using `get_lastcommentmodified` and roughly [https://raw.githubusercontent.com/stevenkword/WordPress-Plugin-Directory-Slurper/master/get_lastpostmodified.txt 100 plugins] are making calls to `get_lastpostmodified`. Looking at some of those plugin names, I am not sure we should deprecate the functions since the expected behavior might be slightly different.
    1515
    1616The existing core functions both return a cached value that is relevant to all content, system wide.  This might be useful for things like timestamps for sitemaps.  On the other hand, the proposed function `get_last_build_date_feed` was designed to return the timestamp related to the most recently modified unit of content on any given request.  This provides a level of granularity that previously did not exist for things like category feeds, independently of each other.