Not able to cancel update popup

[abhayvishwakarma]

When I goto Tools->Import and try to install any plugin for importing data, it shows popup which does not get closed.
Please refer the image
​https://drive.google.com/file/d/1Uh84AuWvKBu_CfaolL4fpMzoJg7hXFep/view?usp=sharing

[abhayvishwakarma]

WordPress Version 5.0.2

[fahimmurshed]

Hi,
Welcome here.

Looks you have permission error on the site.

Add this code to the WordPress wp-config.php file.

define('FS_METHOD', 'direct');

Check this screenshot:

Your problem will be solved.

Let me know it works or not.

[abhayvishwakarma]

Screenshot#2

[abhayvishwakarma]

I know that we can use this constant, but the issue is with the popup.
Please see the Screenshot2

[afercia]

The JS error Uncaught TypeError: Cannot read property 'replace' of undefined happens when trying to close the modal, either by clicking on the "Cancel" button or when clicking outside of the modal.

Seems to me this error has been introduced in WP 4.8, couldn't reproduce in 4.7.

[afercia]

Seems to me [40034] changed the l10n string installNowLabel to pluginInstallNowLabel but installNowLabel is still used for the importers.

[afercia]

45765.diff​ uses pluginInstallNowLabel and updates the default string for consistency.

[abhayvishwakarma]

Hi @afercia,
I am using WordPress Version 5.0.2

[desrosj]

I was able to reproduce this on 5.0.2. 45765.diff​ fixed the issue for me. @abhayvishwakarma are you able to test this patch and confirm? Otherwise, looks good!

[desrosj]

5.1 will be released shortly after 5.0.3, and as this is not within the 5.0.3 focuses (block editor bugs, regressions, and major bugs), it can wait.

[SergeyBiryukov]

In 44417:

Importers: Use correct l10n variable in wp.updates.installImporterError and filesystem credentials dialog.

Missed in [40034].

Props afercia, abhayvishwakarma.
Fixes #45765.