Expose JSON translation file paths

[swissspidy]

As noted by @johnbillion in 45425#comment:5, the potential translation file paths aren't exposed in load_script_textdomain() / load_script_translations().

The determined paths are only passed to load_script_translations() when the files exist. If they don't, load_script_translations() only receives false.

This way it's impossible to hook into this for proper debugging like in ​Query Monitor, or adding language fallbacks like in the ​Preferred Languages feature plugin.

[swissspidy]

cc @herregroen for review

[herregroen]

@swissspidy Patch looks good!

[johnbillion]

I can't test this right now but it looks like this causes all the processing in load_script_textdomain() to run three times if there are no translation files present. At the moment, the file_exists() checks guard against this.

[swissspidy]

I don't see how this would run all of that three times. 🤔It just goes through the whole function and calls load_script_translations() for all cases instead of returning early.

[desrosj]

@johnbillion have you had a chance to test this? It would be great to get this into 5.0.3.

[johnbillion]

Tested and looking good!

[ocean90]

I think we shouldn't call load_script_translations() if $path wasn't set like before, see 45769.2.diff​.

[ocean90]

@swissspidy Can you confirm that 45769.2.diff​ would still work with whatever you had in mind for making it compatible with Preferred Languages?

[swissspidy]

Just tested and it works like a charm with the changes made to Preferred Languages! Feel free to commit :-)

[ocean90]

In 44418:

I18n: Expose JSON translation file paths in load_script_textdomain().

Removes file_exist() checks before calling load_script_translations() to let the determined paths be passed to load_script_translations() which provides its own file check and the possibility to filter the path.

Props swissspidy, johnbillion, ocean90.
See #45769.

[ocean90]

In 44419:

I18N: Expose JSON translation file paths in load_script_textdomain().

Removes file_exist() checks before calling load_script_translations() to let the determined paths be passed to load_script_translations() which provides its own file check and the possibility to filter the path.

Merge of [44418] to the 5.0 branch.

Props swissspidy, johnbillion, ocean90.
Fixes #45769.