WordPress.org

Make WordPress Core

Opened 12 months ago

Closed 6 weeks ago

#45777 closed enhancement (fixed)

@global tag is not present in function login_header().

Reported by: priyankabehera155 Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch
Focuses: docs Cc:
PR Number:

Description

There is a global variable present global $error, $interim_login, $action but these variables are not present in the doc/comment with @global tag.

Attachments (3)

45777.diff (675 bytes) - added by faisal03 12 months ago.
45777_ProperFormat.diff (809 bytes) - added by faisal03 12 months ago.
The previous attachment 45777.diff was not in a proper format so uploaded this one.
45777.patch (1.1 KB) - added by mukesh27 12 months ago.
Remove description as system does not contain those global variables any where so it is better to remove description for now.

Download all attachments as: .zip

Change History (11)

@faisal03
12 months ago

@faisal03
12 months ago

The previous attachment 45777.diff was not in a proper format so uploaded this one.

@mukesh27
12 months ago

Remove description as system does not contain those global variables any where so it is better to remove description for now.

#1 @mukesh27
12 months ago

  • Focuses docs added
  • Keywords has-patch added

#2 follow-up: @priyankabehera155
12 months ago

Hello @mukesh27 ,

Thanks for the patch, but I think the variables are in use and if even if it would not have been used then also we should add proper documentation which includes a description.

#3 in reply to: ↑ 2 @mukesh27
12 months ago

Yes we have to add proper description for all variables but as i say it is better to remove description for now as we don't know what is proper description for those variables.

Replying to priyankabehera155:

Hello @mukesh27 ,

Thanks for the patch, but I think the variables are in use and if even if it would not have been used then also we should add proper documentation which includes a description.

#4 @SergeyBiryukov
11 months ago

  • Milestone changed from Awaiting Review to Future Release
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @SergeyBiryukov
7 months ago

  • Milestone changed from Future Release to 5.3

#6 @davidbaumwald
3 months ago

  • Keywords commit added

@SergeyBiryukov Can this be merged in time for version 5.3 Beta 1 tomorrow?

#7 @davidbaumwald
3 months ago

  • Keywords commit removed
  • Milestone changed from 5.3 to 5.4

Although doc changes can be made between beta 1 and RC, there are 200 bug tickets still to triage. With 5.3 Beta 1 landing in a couple of hours, this is being moved for consideration in 5.4 If a committer feels this change should be made before RC, they can move it back and commit.

#8 @SergeyBiryukov
6 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 46620:

Docs: Document $error, $interim_login, and $action globals in login_header() and login_footer().

Props priyankabehera155, faisal03, mukesh27, SergeyBiryukov.
Fixes #45777.

Note: See TracTickets for help on using tickets.