@global tag is not present in function login_header().

[priyankabehera155]

There is a global variable present global $error, $interim_login, $action but these variables are not present in the doc/comment with @global tag.

[faisal03]

The previous attachment 45777.diff was not in a proper format so uploaded this one.

[mukesh27]

Remove description as system does not contain those global variables any where so it is better to remove description for now.

[priyankabehera155]

Hello @mukesh27 ,

Thanks for the patch, but I think the variables are in use and if even if it would not have been used then also we should add proper documentation which includes a description.

[mukesh27]

Yes we have to add proper description for all variables but as i say it is better to remove description for now as we don't know what is proper description for those variables.

Replying to priyankabehera155:

Hello @mukesh27 ,

Thanks for the patch, but I think the variables are in use and if even if it would not have been used then also we should add proper documentation which includes a description.

[davidbaumwald]

@SergeyBiryukov Can this be merged in time for version 5.3 Beta 1 tomorrow?

[davidbaumwald]

Although doc changes can be made between beta 1 and RC, there are 200 bug tickets still to triage. With 5.3 Beta 1 landing in a couple of hours, this is being moved for consideration in 5.4 If a committer feels this change should be made before RC, they can move it back and commit.

[SergeyBiryukov]

In 46620:

Docs: Document $error, $interim_login, and $action globals in login_header() and login_footer().

Props priyankabehera155, faisal03, mukesh27, SergeyBiryukov.
Fixes #45777.

[SergeyBiryukov]

#38746 was marked as a duplicate.