WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 7 weeks ago

#45777 reviewing enhancement

@global tag is not present in function login_header().

Reported by: priyankabehera155 Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch
Focuses: docs Cc:

Description

There is a global variable present global $error, $interim_login, $action but these variables are not present in the doc/comment with @global tag.

Attachments (3)

45777.diff (675 bytes) - added by faisal03 6 months ago.
45777_ProperFormat.diff (809 bytes) - added by faisal03 6 months ago.
The previous attachment 45777.diff was not in a proper format so uploaded this one.
45777.patch (1.1 KB) - added by mukesh27 6 months ago.
Remove description as system does not contain those global variables any where so it is better to remove description for now.

Download all attachments as: .zip

Change History (8)

@faisal03
6 months ago

@faisal03
6 months ago

The previous attachment 45777.diff was not in a proper format so uploaded this one.

@mukesh27
6 months ago

Remove description as system does not contain those global variables any where so it is better to remove description for now.

#1 @mukesh27
6 months ago

  • Focuses docs added
  • Keywords has-patch added

#2 follow-up: @priyankabehera155
6 months ago

Hello @mukesh27 ,

Thanks for the patch, but I think the variables are in use and if even if it would not have been used then also we should add proper documentation which includes a description.

#3 in reply to: ↑ 2 @mukesh27
6 months ago

Yes we have to add proper description for all variables but as i say it is better to remove description for now as we don't know what is proper description for those variables.

Replying to priyankabehera155:

Hello @mukesh27 ,

Thanks for the patch, but I think the variables are in use and if even if it would not have been used then also we should add proper documentation which includes a description.

#4 @SergeyBiryukov
6 months ago

  • Milestone changed from Awaiting Review to Future Release
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @SergeyBiryukov
7 weeks ago

  • Milestone changed from Future Release to 5.3
Note: See TracTickets for help on using tickets.