Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #45785, comment 11


Ignore:
Timestamp:
11/23/2020 06:07:31 AM (4 years ago)
Author:
TimoTijhof
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #45785, comment 11

    initial v1  
    1 I've taken a brief look at this, and don't see any link between Underscore and QUnit here. THe upstream test suite by Undescore.js itself also uses QUnit which seems to pass fine.
     1I've taken a brief look at this, and don't see any link between Underscore and QUnit here. (Note that the upstream test suite for Undescore.js itself also uses QUnit, which is passing.)
    22
    3 Neither of them modify setTimeout. However, I notice the error above mentioned Sinon and sinon-qunit. Sinon can modify the setTimeout reference globally, I suspect might be what's causing an issue here.
     3Neither of QUnit nor Underscore modifies setTimeout, however. I do notice the error above mentions Sinon and sinon-qunit, which do modify the setTimeout reference globally. I suspect that might be what's causing an issue here.
    44
    55