WordPress.org

Make WordPress Core

Opened 17 months ago

Closed 13 months ago

Last modified 13 months ago

#45789 closed enhancement (worksforme)

Block List: Does not recognize the current state

Reported by: La Geek Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.0.2
Component: Editor Keywords:
Focuses: Cc:

Description

Block list, WP 5.0.2
mouse hover icons ordered list and unordered list, it always says: "convert to xx list"

Attachments (1)

convert_to.gif (248.1 KB) - added by La Geek 17 months ago.

Download all attachments as: .zip

Change History (10)

@La Geek
17 months ago

#1 @swissspidy
17 months ago

  • Component changed from I18N to Editor

What's your expected behaviour?

I don't think we can disable the button for accessibility and usability reasons.

Also, changing the wording to something like "This list is already unordered" sounds weird to me.

#2 @La Geek
17 months ago

Maybe both strings could be renamed to only "ordered list" and "unordered list" and "convert to" could be removed completely.

Atm it is nonsens and confusing, you can't convert something that is already converted.

You can't change black to black ;-)

Last edited 17 months ago by La Geek (previous) (diff)

#3 @La Geek
17 months ago

In the case the programming does recognize the state and the list shows an ordered list, the icons should be

Ordered List <---> Convert to Unordered List

When the list is an unordered one, the icons should be

Convert to Ordered List <---> Unordered List

#4 @afercia
17 months ago

Generally, UI control names shouldn't change dynamically to represent the underlying state. Name and state are two different things.

This applies to all users and especially to assistive technologies users. Imagine screen reader users or speech input users: once they learn a control name is "xyz", they will search for and try to use that control name. For example. as a speech input user I learn a control's name is "Italic": voicing the command "Click Italic" will activate the control. But if the control's name changes once it gets activated, I'd be forced to discover what the new control's name is and voice that instead. Less than ideal.

Probably both strings could be changed from "convert to ordered list" to (only) "ordered list", the same for "unordered list".

I'd second it: the shorter, the better. Also, in the Classic Editor, these buttons are simply named "Bulleted list" and "Numbered list". Not sure why their name has been changed in the first place.

#5 @La Geek
17 months ago

For consistency purposes the short names "Bulleted list" and "Numbered list" would be the best.

#6 @swissspidy
17 months ago

  • Keywords needs-patch added
  • Type changed from defect (bug) to enhancement

#7 @La Geek
13 months ago

  • Resolution set to worksforme
  • Status changed from new to closed

Does work now as expected (in 5.2)

#8 @La Geek
13 months ago

  • Keywords close added; needs-patch removed

#9 @desrosj
13 months ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.