WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 6 months ago

#45791 closed defect (bug) (fixed)

Restore the TinyMCE Help modal keyboard shortcut for the Classic Editor plugin

Reported by: afercia Owned by: audrasjb
Milestone: 5.2 Priority: normal
Severity: normal Version: 5.0
Component: TinyMCE Keywords: has-screenshots needs-patch
Focuses: accessibility Cc:

Description

[44257] removed the keyboard shortcut to open the TinyMCE help modal. In Gutenberg, this shortcut now opens the "global" help modal.

However, when the Classic Editor plugin is activated, the tooltip still displays the keyboard shortcut even if the shortcut doesn't do anything:

http://cldup.com/DGfPkjKNyv.png

Instead of removing the displayed shortcut from the tooltip, I'd propose to restore it only when Classic Editor is used, much like what was done for the access+z shortcut, see https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js?rev=44257#L670. This wouldn't affect anything in Gutenberg and seems pretty easy to implement.

Also, worth considering when https://github.com/WordPress/gutenberg/issues/6195 will be addressed, the shortcut will be displayed also in the tooltip in the Gutenberg Classic block. However, it now opens the "global" help modal. Should the passed string check for the editor type and display the shortcut conditionally?

Change History (14)

#1 @afercia
9 months ago

See also #39271 which mentions all the shortcuts that use Control+Option+something.

#2 @SergeyBiryukov
9 months ago

  • Keywords needs-patch added

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


8 months ago

#4 @afercia
8 months ago

  • Milestone changed from Awaiting Review to 5.1.1
  • Owner set to audrasjb
  • Status changed from new to assigned

Discussed during today's accessibility bug scrub. Agreed to move this ticket to 5.1.x and assign JB as owner.

#5 @azaozz
8 months ago

[44257] removed the keyboard shortcut to open the TinyMCE help modal
...
However, when the Classic Editor plugin is activated, the tooltip still displays the keyboard shortcut even if the shortcut doesn't do anything

That's not (shouldn't be) the case? :)

The shortcut (should) work as always in the Classic Editor and the Classic Block (when focused). [44257] prevents that shortcut from triggering both help modals at the same time in the Block Editor.

#6 follow-up: @afercia
8 months ago

Yeah I understand the purpose of [44257] but with the Classic Editor plugin activated, the shortcut doesn't work :)

Also to note: the iframe title still instructs screen reader users to use that shortcut: Rich Text Area. Press Control-Option-H for help.

#7 in reply to: ↑ 6 @azaozz
8 months ago

Replying to afercia:

Hmmm, seems to work here in both Classic Block and Classic Editor, Alt+Shift+H on Win10. Tested in Firefox, Chrome and Edge.

The iframe tag in Classic Editor is also correct as far as I see:

<iframe id="content_ifr" frameborder="0" allowtransparency="true" title="Rich Text Area. Press Alt-Shift-H for help." style="width: 100%; height: 300px; display: block;"></iframe>

Or perhaps I'm misunderstanding where to look? :)

#8 @afercia
8 months ago

Ah then it must be macOS specific? Interestingly, I've just noticed:

Control Option H doesn't work

Shift Option H does work. However, it is supposed to be Control-Option-H.

The iframe title is fine, was just saying that it's misleading as it creates the expectation the shortcut is available, while it actually isn't.

This ticket was mentioned in Slack in #core-editor by lukecarbis. View the logs.


7 months ago

This ticket was mentioned in Slack in #core by lukecarbis. View the logs.


7 months ago

#11 @lukecarbis
7 months ago

  • Milestone changed from 5.1.1 to 5.2

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


6 months ago

#13 @azaozz
6 months ago

Uh, I see where that comes from. It only tests for event.shiftKey && event.altKey (which on Mac is used for typing accent characters, etc.). Should look at the OS first.

#14 @azaozz
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44913:

TinyMCE: fix the TinyMCE help modal keyboard shortcut on Mac for the classic editor and classic block.

Fixes #45791.

Note: See TracTickets for help on using tickets.