#45794 closed defect (bug) (fixed)
px/rem order reversed in Twenty Twelve blocks.css
Reported by: | superpoincare | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.0.3 | Priority: | normal |
Severity: | minor | Version: | 5.0.2 |
Component: | Bundled Theme | Keywords: | fixed-major |
Focuses: | Cc: |
Description
In the new blocks.css file for Twenty Twelve, px overrides rem in 2 styles, when it should be reversed:
.wp-block-quote:not(.is-large):not(.is-style-large) { border: 0; padding: 1.714285714rem; padding: 24px; } .wp-block-quote { padding: 1.714285714rem; padding: 24px; }
Change History (7)
#1
@
6 years ago
- Keywords needs-patch good-first-bug added
- Milestone changed from Awaiting Review to 5.0.3
#2
@
6 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 44432:
#3
@
6 years ago
- Keywords fixed-major added; needs-patch good-first-bug removed
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for merging to the 5.0 branch.
This ticket was mentioned in Slack in #core by desrosj. View the logs.
6 years ago
#6
follow-up:
↓ 7
@
6 years ago
Maybe the version needs a change here---the date, or is it not important?
// Theme block stylesheet. wp_enqueue_style( 'twentytwelve-block-style', get_template_directory_uri() . '/css/blocks.css', array( 'twentytwelve-style' ), '20181230' );
#7
in reply to:
↑ 6
@
6 years ago
Replying to superpoincare:
Maybe the version needs a change here---the date, or is it not important?
[44434] updated it from 20181018
to 20181230
for 5.0.3.
It could have been updated to 20190107
to reflect the latest change here, but that doesn't seem really necessary, as the value is only used for cache busting.
Note: See
TracTickets for help on using
tickets.
Introduced in [43795], other themes appear to be unaffected.
Since we're updating the theme for 5.0.3 in [44381] and [44382] anyway, this seems simple enough to make it in as well.