Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#45844 closed defect (bug) (invalid)

add_theme_support function doesn't add some features it says in comments

Reported by: superpoincare Owned by:
Priority: normal Milestone:
Component: Themes Version: 5.0
Severity: normal Keywords:
Cc: Focuses:

Description

The lines https://github.com/WordPress/WordPress/blob/master/wp-includes/theme.php#L2321-L2330

say that in 5.0.0 some features were adding to the function add_theme_feature:

"... 'editor-styles', and 'wp-block-styles' features were added."

However the function below doesn't add them.

Change History (4)

#1 @joyously
8 years ago

There was no code change needed to add those new features, so only a comment was added to document the names.

#2 @desrosj
8 years ago

  • Keywords reporter-feedback added
  • Version 5.0.25.0

Hi @superpoincare,

Thanks for the ticket! Can you post code that shows this is not working as expected? The last line of the function adds theme support for the specified feature. The switch() statement only handles more complex features that have additional arguments passed.

#3 @superpoincare
8 years ago

Oh my misunderstanding then.

Trying to figure this previous ticket I raised, reached me to that wrong conclusion: https://core.trac.wordpress.org/ticket/45551

That ticket is valid though: child theme doesn't load parent editor-style.css in the new editor.

Version 1, edited 8 years ago by superpoincare (previous) (next) (diff)

#4 @SergeyBiryukov
8 years ago

  • Component GeneralThemes
  • Keywords reporter-feedback removed
  • Milestone Awaiting Review
  • Resolutioninvalid
  • Status newclosed

Closing per comment:2.

Note: See TracTickets for help on using tickets.