Opened 7 years ago
Closed 7 years ago
#45844 closed defect (bug) (invalid)
add_theme_support function doesn't add some features it says in comments
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | 5.0 |
| Component: | Themes | Keywords: | |
| Focuses: | Cc: |
Description
The lines https://github.com/WordPress/WordPress/blob/master/wp-includes/theme.php#L2321-L2330
say that in 5.0.0 some features were adding to the function add_theme_feature:
"... 'editor-styles', and 'wp-block-styles' features were added."
However the function below doesn't add them.
Change History (4)
#2
@
7 years ago
- Keywords reporter-feedback added
- Version changed from 5.0.2 to 5.0
Hi @superpoincare,
Thanks for the ticket! Can you post code that shows this is not working as expected? The last line of the function adds theme support for the specified feature. The switch() statement only handles more complex features that have additional arguments passed.
#3
@
7 years ago
Oh my misunderstanding then.
Trying to figure this previous ticket I raised, reached me to that wrong conclusion: https://core.trac.wordpress.org/ticket/45551
That ticket is valid though: child theme doesn't load parent editor-style.css in the new editor.
There was no code change needed to add those new features, so only a comment was added to document the names.