Changes between Initial Version and Version 1 of Ticket #45845, comment 13
- Timestamp:
- 03/13/2019 08:55:33 PM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #45845, comment 13
initial v1 6 6 All subsequent tests in the file that call `check_password_reset_key` are looking for expected errors. However, they are just `assertInstanceOf` using `WP_Error`. They aren't checking the ''specific'' error. Since the user is cached and the `user_activation_key` is empty, they will pass these assertions, albeit for the wrong reasons. 7 7 8 There is a preceding test case for `test_password_length_limit` in which `get_user_by` is also referenced. That test pass sesbut that's because the user cache is reset by the `wp_set_password` before assertions are made.8 There is a preceding test case for `test_password_length_limit` in which `get_user_by` is also referenced. That test passes, but that's because the user cache is reset by the `wp_set_password` before assertions are made. 9 9 10 10 Let me know if you'd like me to dig into anything else. Happy to help.