Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #45845, comment 13


Ignore:
Timestamp:
03/13/2019 08:55:33 PM (7 years ago)
Author:
davidbaumwald
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #45845, comment 13

    initial v1  
    66All subsequent tests in the file that call `check_password_reset_key` are looking for expected errors.  However, they are just `assertInstanceOf` using `WP_Error`.  They aren't checking the ''specific'' error.  Since the user is cached and the `user_activation_key` is empty, they will pass these assertions, albeit for the wrong reasons.
    77
    8 There is a preceding test case for `test_password_length_limit` in which `get_user_by` is also referenced.  That test passses but that's because the user cache is reset by the `wp_set_password` before assertions are made.
     8There is a preceding test case for `test_password_length_limit` in which `get_user_by` is also referenced.  That test passes, but that's because the user cache is reset by the `wp_set_password` before assertions are made.
    99
    1010Let me know if you'd like me to dig into anything else.  Happy to help.