Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#45856 closed defect (bug) (invalid)

Link to Classic Editor plugin needs to be translatable

Reported by: tobifjellner's profile tobifjellner Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.1
Component: Editor Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

[44437] introduced a message to the user that JavaScript is needed to run the Block editor. And it nicely suggests using Classic Editor plugin as an alternative solution.
BUT the link to the plugin page https://wordpress.org/plugins/classic-editor/
needs to be translatable, since, for Swedish I'd like to point to https://sv.wordpress.org/plugins/classic-editor/ instead, where the description will be in Swedish.

Change History (4)

#1 @SergeyBiryukov
6 years ago

  • Description modified (diff)

Unless I'm missing something, the link is already translatable:

 __( 'https://wordpress.org/plugins/classic-editor/' )

The translator comment might be confusing though:

/* translators: %s: https://wordpress.org/plugins/classic-editor/ */

It could be just Classic Editor plugin URL instead of the URL itself.

#2 @tobifjellner
6 years ago

  • Resolution set to invalid
  • Status changed from new to closed

Oops. My mistake. Closing. :)

#3 @SergeyBiryukov
6 years ago

In 44665:

I18N: Update translator comment for the notice displayed when viewing the block editor with JavaScript disabled.

A URL in the comment creates an impression that the link is not translatable.

See #45453, #45856.

#4 @desrosj
6 years ago

  • Milestone Awaiting Review deleted

Removing Awaiting Review milestone from closed tickets.

Note: See TracTickets for help on using tickets.