WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#45859 closed defect (bug) (invalid)

Not having aria-label tag in the Publish button

Reported by: priyankabehera155's profile priyankabehera155 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: accessibility Cc:

Description

There is area-label tag is missing in the Publish button.

Attachments (3)

Screenshot-1​ (181.6 KB) - added by priyankabehera155 6 years ago.
45859.diff​ (790 bytes) - added by mukesh27 6 years ago.
Patch.
Screenshot-1.jpg​ (138.4 KB) - added by priyankabehera155 6 years ago.
Button Screenshot

Download all attachments as: .zip

Change History (7)

@priyankabehera155
6 years ago

@mukesh27
6 years ago

Patch.

#1 @mukesh27
6 years ago

  • Keywords has-patch dev-feedback added

@priyankabehera155 please attached current screenshot as above screenshot is not working for us.

@priyankabehera155
6 years ago

Button Screenshot

#2 @priyankabehera155
6 years ago

@mukesh27 added the screenshot

#3 @afercia
6 years ago

  • Keywords dev-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed
  • Version 5.0.2 deleted

@priyankabehera155 thanks and welcome to Trac!

The ​aria-label attribute is meant to give an element a name that can be announced by assistive technologies. When an element already has visible text, the name is given by its text. The Publish button already has visible text, thus it doesn't need an aria-label.

@mukesh27 thanks for the patch :) However, patches shouldn't be made against files in the dist directory. Any change to the Block Editor should be made on the Gutenberg GitHub repository.

I'm going to close this ticket, please do feel free to reopen if I'm missing something.

#4 @priyankabehera155
6 years ago

@afercia Thanks for sharing the information it is really helpful.

Note: See TracTickets for help on using tickets.