#45863 closed defect (bug) (fixed)
Run core unit tests from src again
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | 5.1 |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | Cc: |
Description
After [44359] we can run WordPress develop from src
again, but the restriction for the tests is still in place. Let's get rid of that restriction.
Attachments (1)
Change History (14)
#2
@
4 years ago
I think it would be worthwhile maintaining the ability to run the tests from the build
directory, including a Travis CI job running from the build
directory using the ‘’built’’ source would be beneficial, even more so once E2E tests land.
#3
@
4 years ago
I think you can still run from build
if you change the ABSPATH
in wp-tests-config.php
.
#5
@
4 years ago
- Milestone changed from Awaiting Review to 5.1
- Owner set to pento
- Status changed from new to assigned
#10
@
4 years ago
Travis is failing horribly, see this test output: https://travis-ci.org/WordPress/wordpress-develop/builds/477267171
@atimmer: Can you please investigate?
#12
@
4 years ago
- Resolution set to fixed
- Status changed from reopened to closed
Thinking about this a bit more, I think we can close this now.
Locally, it is possible to run both from src
and build
. This fulfills the development desire.
Travis always runs from build, that is ok because the only tests where running from src
or build
matters are tests regarding assets. When testing from build
we verify that the eventual assets in the build will be in a state that passes the unit tests.
@johnbillion @schlessera I am not 100% confident about this change, if you have time can you check if this patch makes sense?