WordPress.org

Make WordPress Core

Opened 19 months ago

Closed 4 weeks ago

Last modified 4 weeks ago

#45866 closed defect (bug) (fixed)

Twenty Nineteen: Long submenu item titles do not wrap

Reported by: kjellr Owned by: ianbelanger
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch
Focuses: css Cc:

Description

In the latest version of Twenty Nineteen (1.1), long submenu item titles do not wrap on desktop screens (looks like there's a whitespace: nowrap; rule applied to .main-navigation .sub-menu > li > a).

https://cldup.com/P4ghkyXNC8-3000x3000.png

These should wrap when necessary, and wrapped lines should be indented as in the following mockup:

https://cldup.com/PVn2wvPEBF-1200x1200.png

Attachments (2)

45866.patch (1.2 KB) - added by mohsinrasool 12 months ago.
Patch to set fix width issue of the submenu item in both .scss and .css files.
45866.2.patch (1.2 KB) - added by mukesh27 2 months ago.
Updated patch.

Download all attachments as: .zip

Change History (12)

#1 @mukesh27
19 months ago

In my case i have to remove whitespace: nowrap; from .main-navigation .sub-menu > li > a and also needs to change min-width: min-width: max-content; to min-width: min-width: 250px;

#2 @laurelfulford
18 months ago

  • Keywords has-screenshots added
  • Milestone changed from Awaiting Review to Future Release

@mohsinrasool
12 months ago

Patch to set fix width issue of the submenu item in both .scss and .css files.

#3 @mohsinrasool
12 months ago

  • Keywords has-patch added; needs-patch removed

Added a patch to set fix width issue of the submenu item in both .scss and .css files. I am starting to contribute in WordPress. Do let me know if something wrong with my fixes.

Thanks

#4 @ianbelanger
5 months ago

  • Focuses css added
  • Milestone changed from Future Release to 5.5

#5 @samful
2 months ago

The patch needs a very quick refresh since it hasn't been committed for 9 months and some lines have moved about, but the rules work and fixes the problem. Hope this is committed sooner rather than later.

@mukesh27
2 months ago

Updated patch.

#6 @ianbelanger
7 weeks ago

  • Owner set to ianbelanger
  • Status changed from new to reviewing

Reviewing for commit.

#7 @ianbelanger
7 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48032:

Bundled Themes: Twenty Nineteen long submenu item titles do not wrap.

Fixes the issue of long submenu item titles that do not wrap by adding a max-width: 20rem; and removing white-space: nowrap;.

Props kjellr, mukesh27, mohsinrasool, samful.
Fixes #45866.

#8 @ianbelanger
7 weeks ago

  • Keywords fixed-major added
  • Milestone changed from 5.5 to 5.4.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#9 @desrosj
4 weeks ago

  • Keywords fixed-major removed
  • Resolution set to fixed
  • Status changed from reopened to closed

With 5.5 just under 5 weeks away, there is no 5.4.3 planned. Moving back to the 5.5 milestone.

#10 @desrosj
4 weeks ago

  • Milestone changed from 5.4.3 to 5.5
Note: See TracTickets for help on using tickets.