WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 2 years ago

Last modified 2 years ago

#45867 closed defect (bug) (fixed)

Simplify Tests_External_HTTP_Basic Integration Test

Reported by: bbobnis's profile bbobnis Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

bbobnis [3:09 PM]
​https://github.com/WordPress/wordpress-develop/blob/6b366c6620fdd5960cedcdf80955966a715efa82/tests/phpunit/tests/external-http/basic.php is a strange test. Consider example.com for external HTTP integration tests as in other tests in this package.
desrosj [3:11 PM]
@bbobnis Do you mind opening a ticket on Trac

Recommendation made after noticing two failing builds:

Change History (13)

#1 @sabernhardt
4 years ago

  • Component changed from General to Build/Test Tools

This ticket was mentioned in ​PR #2950 on ​WordPress/wordpress-develop by ​ironprogrammer.
2 years ago #2

  • Keywords has-patch has-unit-tests added

Migrates tests designated for External_HTTP_Basic (which doesn't exist) to a new location for better context. Also updates test names for clarity, and @covers annotations to @coversNothing.

Trac ticket: https://core.trac.wordpress.org/ticket/45867

#3 @ironprogrammer
2 years ago

Submitted ​PR 2950 for consideration.

These tests validate the PHP and MySQL/MariaDB versions used in readme.html. The test class has been renamed and moved into a file with a more appropriate name.

Props costdev, hellofromTonya.

Related: #39265.

This ticket was mentioned in ​Slack in #core by azaozz. ​View the logs.
2 years ago

#5 @azaozz
2 years ago

  • Keywords close added

Seems fixed (or partially fixed?) in [53686].

Edit: ugh, disregard, that is for phpunit/tests/basic.php not for
phpunit/tests/external-http/basic.php (yea, duplicate names are bad!).

Last edited 2 years ago by azaozz (previous) (diff)

#6 @azaozz
2 years ago

  • Keywords close removed

#7 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 6.1
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

This ticket was mentioned in ​Slack in #core by chaion07. ​View the logs.
2 years ago

#9 @chaion07
2 years ago

@bbobnis thank you for reporting this. We reviewed this ticket during a recent bug-scrub session. Here's a summary of the feedback received:

  1. This ticket has a pull request which passed all tests.
  2. There is a conflict which needs to be resolved for merging.

Cheers!

Props to @priyomukul

#10 @ironprogrammer
2 years ago

​PR 2950 has been refreshed against trunk, and is ready for final review.

#11 @ironprogrammer
2 years ago

Noting here that the updated tests pass (excluding the intentionally skipped PHP version check).

phpunit --testdox --group external-http --filter tests_readme.

#12 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 54479:

Tests: Relocate the tests for recommended PHP, MySQL, and MariaDB versions.

This commit moves the tests for recommended versions of dependencies referenced in readme.html to a new location for better context. Also updates test class name for clarity, and @covers annotations to @coversNothing.

Follow-up to [26166], [33946], [35172], [52418], [52424].

Props ironprogrammer, bbobnis, antonvlasenko, azaozz, chaion07, priyomukul.
Fixes #45867.

​SergeyBiryukov commented on ​PR #2950:
2 years ago #13

Thanks for the PR! Merged in r54479.

Note: See TracTickets for help on using tickets.