Opened 5 years ago
Last modified 6 months ago
#45899 new enhancement
Twenty Nineteen: Typographic scale improvements
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | low |
Severity: | normal | Version: | 5.0.2 |
Component: | Bundled Theme | Keywords: | needs-patch close |
Focuses: | accessibility | Cc: |
Description
As noted during the early development of Twenty Nineteen, there are a couple improvements to the font size and typographic scale:
- The theme sets a base font size of
22px
. Ideally, this should be set to100%
. ( Discussion: https://github.com/WordPress/twentynineteen/issues/62 ) - The
em
-based typographic scale built on top of that22px
size does not always resolve to exact pixels. ( Discussion: https://github.com/WordPress/twentynineteen/issues/164 )
It's worth noting that adjusting this scale at this point must:
- Preserve the current appearance. Font sizes must be close enough to what's live currently that they don't appear visually different. Adjusting our math so that type sizes are rounded up/down to the nearest pixel when rendered is fine, but we don't want to implement a whole new, different type scale.
- Use pixel or
rem
-based sizes in the editor styles in order to override the default pixel-based font sizes used in Gutenberg.
Change History (2)
Note: See
TracTickets for help on using
tickets.
As part of the proposal to retire default themes, Twenty Nineteen might not have any more enhancements soon.
It could be too late for this ticket.