Opened 6 years ago
Last modified 10 months ago
#45904 new defect (bug)
Twenty Nineteen: .button doesn't override link color
Reported by: | laurelfulford | Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | 5.0 |
Component: | Bundled Theme | Keywords: | needs-patch has-screenshots |
Focuses: | accessibility, css | Cc: |
Description
Originally reported by @crunnells in Twenty Nineteen's GitHub repo:
I noticed this one the theme demo site when I tried to change the "Get in touch" button into a link. If you put a link inside of an element with the .button
class, the link color is the same color blue as the background, so the text can't be read. The same thing occurs when you try <a href="#" class="button">
, so we'll need to have an override on the link color so that it's readable.
Moved over from: https://github.com/WordPress/twentynineteen/issues/746
Attachments (2)
Change History (7)
#2
@
6 years ago
- Keywords has-screenshots added; needs-screenshots removed
- Milestone changed from Awaiting Review to Future Release
I could recreate this in the widget area, when non-visited links had the .button
class added. The theme's .widget a
styles is overriding the white text colour on the .button
class.
:visited
links display correctly initially. Both :visited
and non-visited links display low contrast on hover (blue text on a black background).
#5
@
10 months ago
Since the widget area is now block-based, I think this could be solved with https://core.trac.wordpress.org/ticket/60408
-Because the theme design for the button block is the same as an element with the custom .button
class.
Twenty Nineteen - links with the class
.button