WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 3 days ago

#45907 new defect (bug)

Twenty Nineteen: Right-aligned, uncaptioned images inserted via the Classic Editor do not extend beyond the text column

Reported by: kjellr Owned by:
Milestone: Future Release Priority: low
Severity: normal Version: 5.0.2
Component: Bundled Theme Keywords: needs-patch good-first-bug
Focuses: Cc:

Description

Originally reported by @joyously on the Twenty Nineteen GitHub repo:

https://github.com/WordPress/twentynineteen/issues/688

The Twenty Nineteen is designed to have right-aligned elements extend beyond the text column like so:

https://cldup.com/jqNamSAitA-1200x1200.png

This works in all cases except under the following conditions:

  1. An image has been inserted via the Classic Editor.
  2. The image is floated right.
  3. The image does not have a caption.

In that case, the image will appear tucked into the text column:

https://cldup.com/b_oMnbi4XQ-1200x1200.png

In that case, the images are housed within paragraph tags. For example:

<p>
  <img src="#" class="alignright">
  This is some text that the image will float around.
</p>

The <p> inherits our max-width styles, and prevents the image from extending beyond the content column. In order to have the image extend beyond the paragraph's width, we'd need to pull it out via negative margins or relative positioning of some sort. The markup would be very different from the markup we're currently using for all other cases though — I'm not personally sure it's worth sorting out for this single use case, but leaving the issue here in case anyone comes across a simple solution.

Change History (3)

#1 @desrosj
11 days ago

  • Component changed from General to Bundled Theme
  • Keywords needs-patch good-first-bug added

This ticket was mentioned in Slack in #core by desrosj. View the logs.


3 days ago

#3 @desrosj
3 days ago

  • Milestone changed from Awaiting Review to Future Release
Note: See TracTickets for help on using tickets.