WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 14 months ago

Last modified 11 months ago

#45908 closed enhancement (wontfix)

Twenty Nineteen: Add version number for all single PHP files for better handling in child themes

Reported by: laurelfulford Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: close
Focuses: docs Cc:

Description

Originally reported in Twenty Nineteen's GitHub repo by @Zodiac1978:

Twenty Nineteen does not have @version numbers in the doc blocks for each file in the theme. These can be used to help make sure files in child themes are up to date.

More discussion from Twenty Seventeen: https://github.com/WordPress/twentyseventeen/issues/72

Original ticket: https://github.com/WordPress/twentynineteen/issues/743

Change History (3)

#1 @desrosj
2 years ago

  • Focuses docs added
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 5.0.2 to 5.0

#2 @zodiac1978
14 months ago

  • Keywords close added; needs-patch removed
  • Resolution set to wontfix
  • Status changed from new to closed

After the release of Twenty Nineteen (and TwentyTwenty!) it doesn't make any sense any more to add those version numbers for single template files.

Although the idea got some nice reviews on the proof of concept plugin ...
https://wordpress.org/plugins/child-theme-check/

and on WP Tavern (and on some other platforms/blogs)...
https://wptavern.com/child-theme-check-plugin-helps-wordpress-users-navigate-parent-theme-updates#comments

.. it doesn't got any traction, has no support from the Theme review team or the developer from the Theme Check plugin and in times of Gutenberg the future of child themes in general is unsure. So I think we safely can close this here (unfortunately) to clean up trac a bit more.

I'm still sad this got no support from anyone. :(

#3 @SergeyBiryukov
11 months ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.