WordPress.org

Make WordPress Core

Opened 15 months ago

Last modified 5 weeks ago

#45912 assigned enhancement

Twenty Nineteen: Horizontal rule is very narrow

Reported by: laurelfulford Owned by: nielslange
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-screenshots good-first-bug has-patch commit
Focuses: css Cc:

Description (last modified by laurelfulford)

Originally reported by @joyously in the Twenty Nineteen GitHub repo:

The <hr> tag outputs a line that is very narrow (max-width: 2.25em), and seems like it would be an unexpected style in legacy content.

It's matches the current default style for the separator block, but it's possible to change that style to be full-width, or centred dots; for the <hr> tag it can't be changed.

For the purpose of preserving the expected visual appearance in legacy content, let's switch its appearance with that of the wide separator block style.

Original ticket here: https://github.com/WordPress/twentynineteen/issues/83

Attachments (2)

83-horizontal-rule.png (5.9 KB) - added by laurelfulford 15 months ago.
Twenty Nineteen three separator block variants. hr tags currently look like the first one, but should be updated to look like the second one.
45912.diff (23.4 KB) - added by nielslange 14 months ago.

Download all attachments as: .zip

Change History (10)

@laurelfulford
15 months ago

Twenty Nineteen three separator block variants. hr tags currently look like the first one, but should be updated to look like the second one.

#1 @laurelfulford
15 months ago

  • Description modified (diff)

#2 @nielslange
15 months ago

Howdy @laurelfulford 👋

I’ld love to provide a patch for this issue the next days! 😉

#3 @laurelfulford
14 months ago

  • Milestone changed from Awaiting Review to Future Release
  • Owner set to nielslange
  • Status changed from new to assigned

Thanks @nielslange!

I'll assign this to you for now, so it's known that it's "taken" :)

#4 @nielslange
14 months ago

Thanks, @laurelfulford.

Last edited 14 months ago by nielslange (previous) (diff)

@nielslange
14 months ago

#5 @nielslange
14 months ago

The patch is ready for testing. 😀

Last edited 14 months ago by nielslange (previous) (diff)

#6 @nielslange
14 months ago

@laurelfulford, @allancole or @kjellr: Anyone up for a quick test? 😛

#7 @kjellr
14 months ago

  • Keywords has-patch added; needs-patch removed

This works for me!

Before:
https://cldup.com/FQCaVSip_t-3000x3000.png

After:
https://cldup.com/1sT08PEfSO-3000x3000.png

Thanks, @nielslange!

#8 @ianbelanger
5 weeks ago

  • Focuses css added
  • Keywords commit added
  • Milestone changed from Future Release to 5.5
  • Version set to 5.0
Note: See TracTickets for help on using tickets.