WordPress.org

Make WordPress Core

Opened 22 months ago

Last modified 6 months ago

#45916 new enhancement

Twenty Nineteen: Consider setting background color and foreground color together

Reported by: allancole Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: good-first-issue good-first-bug has-patch
Focuses: css Cc:

Description

Originally reported by @joyously in the Twenty Nineteen GitHub repo:

On the <body> tag, as a best practice the background-color and text color should always be set together in the main stylesheet. This will make it easier to quickly understand the underlying color scheme.

See here: https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentynineteen/style.css#L765

Original ticket here: https://github.com/WordPress/twentynineteen/issues/64

Attachments (1)

45916.diff (2.1 KB) - added by samful 6 months ago.

Download all attachments as: .zip

Change History (2)

#1 @samful
6 months ago

  • Focuses css added
  • Keywords good-first-bug has-patch added; needs-patch removed

This ticket is from 2018 on github, I submitted a patch to push this along and changed keywords. If this patch is accepted, then the 2017 theme also has the same issues and needs to be patched in the same way. (The 2020 theme does set these together btw)

@samful
6 months ago

Note: See TracTickets for help on using tickets.