Opened 4 years ago
Last modified 34 hours ago
#45916 new enhancement
Twenty Nineteen: Consider setting background color and foreground color together
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 6.3 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Bundled Theme | Keywords: | good-first-issue good-first-bug has-patch changes-requested |
| Focuses: | css | Cc: |
Description
Originally reported by @joyously in the Twenty Nineteen GitHub repo:
On the <body> tag, as a best practice the background-color and text color should always be set together in the main stylesheet. This will make it easier to quickly understand the underlying color scheme.
See here: https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentynineteen/style.css#L765
Original ticket here: https://github.com/WordPress/twentynineteen/issues/64
Attachments (1)
Change History (4)
#2
@
4 weeks ago
- Milestone changed from Awaiting Review to 6.3
The patch still applies. We could also consider moving the background-color to _typography.scss so the two body colors are defined earlier in the stylesheet and before the text color of form elements (button, input, select, optgroup, textarea).
This ticket is from 2018 on github, I submitted a patch to push this along and changed keywords. If this patch is accepted, then the 2017 theme also has the same issues and needs to be patched in the same way. (The 2020 theme does set these together btw)