Twenty Nineteen: Consider adding a search option in the page header

[kjellr]

Originally noted by @dartiss in the Twenty Nineteen GitHub repository:

​https://github.com/WordPress/twentynineteen/issues/583

Twenty Nineteen only has one widget area (in the page footer) and does not allow users to place a search field on the top of the page. Many users would likely benefit from that functionality, so it could be considered for a future release.

[craigtommola]

Curious if this has been looked into further ... I'd suggest that there's a bug beneath the decision to leave out the search field. I'm working in a child theme of 2019 and added a search field both "long hand" and with get_search_form(). On pages which also have navigation (I'm working in a multisite network - some subsites do not have a menu / nav) the search won't work while within div.site-branding ... it loses focus when I try to insert my cursor.

In the event listeners tab of Chrome dev tools, /wp-content/themes/twentynineteen/js/touch-keyboard-navigation.js?ver=1.1 seems to be the culprit? If I comment out the wp_enqueue_script at /wp-content/themes/twentynineteen/functions.php:226 the search field works consistently.

I'm probably going to end up with a bunch of extraneous wrappers to sort this out, but if there's a more correct solution, it'd be much appreciated.

[karmatosed]

I would recommend considering this theme has been released a while we don't add this as it isn't a bug but an enhancement that could seem unexpected to users at this point. This doesn't negate its usefulness but more reflects what the focus is on default themes currently - to fix bugs.

Thank you everyone for collaboration on this and by adding the close keyword that shouldn't stop conversation if someone feels strongly about not following that through.

[karmatosed]

My recommendation stands so moving this to close for now. Thank you everyone and we can always consider if someone wants to raise that.