Make WordPress Core

Opened 5 years ago

Last modified 13 days ago

#45924 new enhancement

Twenty Nineteen: Consider making the "—" divider in the header translatable.

Reported by: kjellr's profile kjellr Owned by:
Milestone: Future Release Priority: low
Severity: normal Version: 5.0.2
Component: Bundled Theme Keywords: has-patch dev-feedback needs-testing
Focuses: Cc:

Description

Twenty Nineteen uses an em dash to separate the site title from the tagline:

https://cldup.com/n92WHtHO2t-3000x3000.png

As originally noted by @pixolin in the Twenty Nineteen GitHub repository, in non-english languages, the em dash is not always the most appropriate/common character for this situation. To address this, we should consider allowing this to be translatable.

Note that the em dash is currently inserted (and hidden when appropriate) via CSS, so this could require a bit of a reworking of that functionality.

Original report: https://github.com/WordPress/twentynineteen/issues/557

Attachments (1)

45924.diff (1.4 KB) - added by truchot 5 years ago.

Download all attachments as: .zip

Change History (5)

#1 @desrosj
5 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

#2 @truchot
5 years ago

  • Keywords has-patch added; needs-patch removed

Here's my suggestion to make "—" translatable (made during WordCamp Paris contributor day)

@truchot
5 years ago

#3 @karmatosed
2 months ago

  • Keywords dev-feedback added

I would be interested in other feedback so lets get that with a label on this.

#4 @karmatosed
13 days ago

  • Keywords needs-testing added
Note: See TracTickets for help on using tickets.