Make WordPress Core

Opened 6 years ago

Closed 3 weeks ago

#45924 closed enhancement (wontfix)

Twenty Nineteen: Consider making the "—" divider in the header translatable.

Reported by: kjellr's profile kjellr Owned by:
Milestone: Priority: low
Severity: normal Version: 5.0.2
Component: Bundled Theme Keywords: has-patch needs-testing close 2nd-opinion
Focuses: Cc:

Description

Twenty Nineteen uses an em dash to separate the site title from the tagline:

https://cldup.com/n92WHtHO2t-3000x3000.png

As originally noted by @pixolin in the Twenty Nineteen GitHub repository, in non-english languages, the em dash is not always the most appropriate/common character for this situation. To address this, we should consider allowing this to be translatable.

Note that the em dash is currently inserted (and hidden when appropriate) via CSS, so this could require a bit of a reworking of that functionality.

Original report: https://github.com/WordPress/twentynineteen/issues/557

Attachments (1)

45924.diff (1.4 KB) - added by truchot 5 years ago.

Download all attachments as: .zip

Change History (8)

#1 @desrosj
6 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

#2 @truchot
5 years ago

  • Keywords has-patch added; needs-patch removed

Here's my suggestion to make "—" translatable (made during WordCamp Paris contributor day)

@truchot
5 years ago

#3 @karmatosed
6 months ago

  • Keywords dev-feedback added

I would be interested in other feedback so lets get that with a label on this.

#4 @karmatosed
4 months ago

  • Keywords needs-testing added

#5 @karmatosed
2 months ago

  • Keywords dev-feedback removed

I feel like this simply needs testing to confirm the approach so moving it to that.

#6 @sabernhardt
4 weeks ago

  • Keywords close 2nd-opinion added

A translatable glyph probably would have been a better choice in 2018, but I do not recommend making the change now.

  1. The :before pseudo-element is in the stylesheet, and it could remain in the styles for sites that copied parts of the main stylesheet into a child theme stylesheet. Those sites would have two dividers.
  2. Anyone who might prefer a different glyph probably has adjusted the CSS—or else switched themes—in the past five years.

Also, the patch does not account for the extra 0.2em margins on the left and right of the divider, which still would be possible if the translatable string adds an HTML element (or placeholders for the open and close tags).

#7 @karmatosed
3 weeks ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I agree with this being closed for now, thank you everyone.

Note: See TracTickets for help on using tickets.