Make WordPress Core

Opened 5 years ago

Closed 4 weeks ago

#45927 closed enhancement (wontfix)

Twenty Nineteen: Add starter content based on the theme demo

Reported by: allancole's profile allancole Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-refresh close 2nd-opinion
Focuses: Cc:

Description

Originally reported by @joyously in the Twenty Nineteen GitHub repo.

As @celloexpressions states:

Starter content is a relatively new feature in core, dating to WordPress 4.7. As a relatively new feature, and given that bundled themes should be "state of the art," it seems like a mandatory element of Twenty Nineteen. We should also consider the goal of starter content to improve the new user experience with fresh installations of WordPress. Leaving this out of Twenty Nineteen would be a regression relative to the current fresh-install experience with Twenty Seventeen.

Let’s go ahead and add some starter content so users have an example of how to recreate the content in the demo.

Included is a patch that replicates the demo content and adds support for it. There are two additional image files attached to this ticket that need to be added to the /img directory of twentynineteen.

Original ticket here: https://github.com/WordPress/twentynineteen/issues/216
Original pull request here: https://github.com/WordPress/twentynineteen/pull/510

Attachments (3)

45927.patch (10.4 KB) - added by allancole 5 years ago.
This patch adds theme support for starter content and includes the starter content itself. There are two image files that are also attached and need to be added to the twentynineteen/img/ directory for the starter content to work properly.
placeholder-image-portrait.png (1.5 KB) - added by allancole 5 years ago.
Portrait placeholder image. Add this file to the twentynineteen/img/ directory.
placeholder-image-landscape.png (3.4 KB) - added by allancole 5 years ago.
Landscape placeholder image. Add this file to the twentynineteen/img/ directory.

Download all attachments as: .zip

Change History (6)

@allancole
5 years ago

This patch adds theme support for starter content and includes the starter content itself. There are two image files that are also attached and need to be added to the twentynineteen/img/ directory for the starter content to work properly.

@allancole
5 years ago

Portrait placeholder image. Add this file to the twentynineteen/img/ directory.

@allancole
5 years ago

Landscape placeholder image. Add this file to the twentynineteen/img/ directory.

#1 @desrosj
5 years ago

  • Milestone changed from Awaiting Review to Future Release

#2 @sabernhardt
10 months ago

  • Keywords needs-refresh close 2nd-opinion added; needs-testing removed

As part of the proposal to retire default themes, Twenty Nineteen might not have any enhancements soon.

Twenty Seventeen, Twenty Twenty, and Twenty Twenty-One all have starter content. If it is still important to add to this theme, please refresh the patch and/or claim ownership of the ticket.

#3 @karmatosed
4 weeks ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I am going to close this ticket as agree with the recommendation by @sabernhardt. Whilst that doesn't mean in the future with the work going on with updating themes this couldn't be considered depending on the approach there and what the iteration is, for now it means closing this makes sense. We can always reopen. Thank you everyone for collaborating on this.

Note: See TracTickets for help on using tickets.