Changes between Version 2 and Version 3 of Ticket #45933, comment 35
- Timestamp:
- 01/21/2019 11:16:05 AM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #45933, comment 35
v2 v3 5 5 - `$args['response']` seems to have both `0` (line 3327) as well as `500` (line 3375) as default values. If it should be `0`, then some of the calls will be wrong, as setting of return code 500 is removed in some places by the patch (line 3024, line 3218, line 3257). 6 6 - `'code'` should be an integer but defaults to an empty string (line 3328). 7 - `'text_direction'` could default to ` ltr` to simplify the code (line 3332).7 - `'text_direction'` could default to `'ltr'` to simplify the code (line 3332). 8 8 9 9