WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 5 weeks ago

#45935 closed defect (bug) (fixed)

A URL in do_block_editor_incompatible_meta_box function does not have classic-editor__forget parameter

Reported by: tmatsuur Owned by: pento
Milestone: 5.2.3 Priority: normal
Severity: normal Version: 5.0
Component: Editor Keywords: has-patch needs-testing fixed-major
Focuses: Cc:

Description

If there is an incompatible meta box in the block editor, a link to switch to the classic editor will be displayed.
Clicking this link does not switch to the classic editor depending on the post data.

do_block_editor_incompatible_meta_box function(/wp-admin/includes/template.php)

$edit_url = add_query_arg( 'classic-editor', '', get_edit_post_link( $object ) );

In this part, I think that you need the classic-editorforget parameter as shown below.

$edit_url = add_query_arg( array( 'classic-editor'=>'', 'classic-editor__forget'=>'' ), get_edit_post_link( $object ) );

Attachments (1)

45935.diff (740 bytes) - added by mukesh27 8 months ago.
Patch tested in WordPress Beta version 5.1-beta1-44558

Download all attachments as: .zip

Change History (8)

#1 @mukesh27
8 months ago

  • Component changed from General to Editor
  • Keywords has-patch added

@tmatsuur that issue is already fixed in Classic Editor plugin https://wordpress.org/support/topic/switching-to-classic-editor-from-block-editor-doesnt-work/ but not resolve in core software.

@mukesh27
8 months ago

Patch tested in WordPress Beta version 5.1-beta1-44558

#2 @tmatsuur
8 months ago

@mukesh27 thanks.

#3 @earnjam
8 months ago

  • Version set to 5.0

#4 @pento
2 months ago

  • Milestone changed from Awaiting Review to 5.3
  • Owner set to pento
  • Status changed from new to assigned

#5 @pento
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45618:

Block Editor: Fix the link to the classic editor when incompatible meta boxen are detected.

Props tmatsuur, mukesh27.
Fixes #45935.

#6 @JeffPaul
5 weeks ago

  • Keywords needs-testing fixed-major added
  • Milestone changed from 5.3 to 5.2.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this so it can be back-ported to the 5.2 branch, also needs testing to validate if this ticket is good to land in 5.2.3.

#7 @SergeyBiryukov
5 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45848:

Block Editor: Fix the link to the classic editor when incompatible meta boxen are detected.

Props tmatsuur, mukesh27.
Merges [45618] to the 5.2 branch.
Fixes #45935.

Note: See TracTickets for help on using tickets.