Opened 7 years ago
Last modified 4 months ago
#45939 reopened defect (bug)
Coding Standards: fix <br/> in core files
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Future Release | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | General | Keywords: | has-patch |
| Focuses: | coding-standards | Cc: |
Description
In order to self-closing-elements, a single space should precede the self-closing slash.
I created this patch for version 5.0.3, but this version isn't on ticket version selector.
Attachments (4)
Change History (12)
#1
@
7 years ago
@man4toman, I audited all <br/> occurrences in the following files:
- src/wp-admin/custom-background.php
- src/wp-admin/edit-comments.php
- src/wp-admin/includes/class-wp-filesystem-base.php
- src/wp-admin/includes/class-wp-ms-users-list-table.php
- src/wp-admin/includes/class-wp-plugins-list-table.php
- src/wp-admin/install.php
- src/wp-admin/network/settings.php
- src/wp-admin/network/site-info.php
- src/wp-admin/options-reading.php
- src/wp-includes/widgets/class-wp-widget-archives.php
#4
@
7 years ago
- Component changed from Administration to General
- Milestone changed from Awaiting Review to Future Release
- Owner set to desrosj
- Status changed from new to reviewing
- Version 5.0.2 deleted
#6
@
5 months ago
- Keywords needs-testing removed
- Resolution set to duplicate
- Status changed from reviewing to closed
#7
follow-up:
↓ 8
@
5 months ago
- Resolution duplicate deleted
- Status changed from closed to reopened
[54062] missed one <br/> that these patches fixed, in the network settings page, so I updated the patch.
(For an alternative approach, the label and checkbox probably could be wrapped in a div instead of using line breaks.)
#8
in reply to:
↑ 7
@
4 months ago
[54062] missed one
<br/>that these patches fixed
I did not mention earlier that Twenty Nineteen also has two <br/> breaks in its single.php template. However, the theme uses <br> for the other four line breaks.
I added a patch for that too, on this ticket, but it could have its own separate commit.
Patch.