WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Last modified 2 weeks ago

#45939 reopened defect (bug)

Coding Standards: fix <br/> in core files

Reported by: man4toman's profile man4toman Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: coding-standards Cc:

Description

In order to ​self-closing-elements, a single space should precede the self-closing slash.

I created this patch for version 5.0.3, but this version isn't on ticket version selector.

Attachments (3)

br-fix.patch​ (1.7 KB) - added by man4toman 6 years ago.
45939.patch​ (9.0 KB) - added by mukesh27 6 years ago.
Patch.
45939.1.patch​ (798 bytes) - added by sabernhardt 2 weeks ago.
add space in <br/> for wp-admin/network/settings.php

Download all attachments as: .zip

Change History (10)

@man4toman
6 years ago

@mukesh27
6 years ago

Patch.

#1 @mukesh27
6 years ago

@man4toman, I audited all <br/> occurrences in the following files:

  • src/wp-admin/custom-background.php
  • src/wp-admin/edit-comments.php
  • src/wp-admin/includes/class-wp-filesystem-base.php
  • src/wp-admin/includes/class-wp-ms-users-list-table.php
  • src/wp-admin/includes/class-wp-plugins-list-table.php
  • src/wp-admin/install.php
  • src/wp-admin/network/settings.php
  • src/wp-admin/network/site-info.php
  • src/wp-admin/options-reading.php
  • src/wp-includes/widgets/class-wp-widget-archives.php

#2 @nielslange
6 years ago

  • Keywords needs-testing added

#3 @mukesh27
6 years ago

#46105 was marked as a duplicate.

#4 @desrosj
6 years ago

  • Component changed from Administration to General
  • Milestone changed from Awaiting Review to Future Release
  • Owner set to desrosj
  • Status changed from new to reviewing
  • Version 5.0.2 deleted

#5 @desrosj
5 years ago

  • Owner desrosj deleted

#6 @SirLouen
2 weeks ago

  • Keywords needs-testing removed
  • Resolution set to duplicate
  • Status changed from reviewing to closed

Duplicate of #56457.

Basically, I've found that in this was already sorted here [54062]

@sabernhardt
2 weeks ago

add space in <br/> for wp-admin/network/settings.php

#7 @sabernhardt
2 weeks ago

  • Resolution duplicate deleted
  • Status changed from closed to reopened

[54062] missed one <br/> that these patches fixed, in the network settings page, so I updated the patch.

(For an alternative approach, the label and checkbox probably could be wrapped in a div instead of using line breaks.)

Note: See TracTickets for help on using tickets.