Make WordPress Core

Opened 6 years ago

Closed 3 months ago

#45943 closed enhancement (wontfix)

Twenty Nineteen: Consider adding additional social media icons

Reported by: kjellr's profile kjellr Owned by:
Milestone: Priority: low
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: close
Focuses: Cc:

Description

There have been a handful of requests for additional icons to be added to the social media links iconset in Twenty Nineteen:

Wikipedia and Discord have working patches already (attached):

https://cldup.com/e-JpiWU-h9-3000x3000.png

Twenty Seventeen has a similar social media iconset included, and has received similar requests: #43342, #45328

I don't see an issue with adding these ones (especially the ones that have patches already), but I will note that we should probably agree on some limitations around these sorts of additions: there are a near-infinite number of social media services out there, and we won't be able to include them all. In addition, each icon added provides a (admittedly very tiny) file size bump, and as these services update their logos over time, there'll be maintenance required to keep these up to date.

Here is the current list of supported icons in Twenty Nineteen, for reference:
https://codex.wordpress.org/Twenty_Nineteen#Add_Social_Icons

Attachments (2)

45943-discord.patch (2.4 KB) - added by kjellr 6 years ago.
45943-wikipedia.patch (6.0 KB) - added by kjellr 6 years ago.

Download all attachments as: .zip

Change History (7)

#1 @silas2209
6 years ago

I think a Discord or Mastodon logo would be nice, but I don't really understand the need for a Wikipedia icon. I don't think anyone wants to link a Wikipedia article in a menu.

#2 @klaas1
6 years ago

@silas2209 I want to link to the corresponding wikipedia article [person or club for example]

#3 @desrosj
2 years ago

  • Version changed from 5.0.3 to 5.0

It was announced that requests for new icons in Twenty Twenty were no longer going to be considered as of WordPress 5.5 (see the Theme Field Guide).

I think that we should confirm the ability to fully add custom icons through filters (similar to #48713) and then take the same policy in Twenty Nineteen.

The block editor has a number of social and website icons available to any site on any theme through blocks. Any new icon requests should probably flow through the Gutenberg repository.

#4 @karmatosed
3 months ago

  • Keywords close added; has-patch removed

Based on the last comment by @desrosj I am going to recommend we close this ticket. Thank you everyone for your collaboration on this.

#5 @karmatosed
3 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

For now, I am going to close this thank you everyone.

Note: See TracTickets for help on using tickets.