WordPress.org

Make WordPress Core

Opened 9 months ago

Last modified 9 months ago

#45943 new enhancement

Twenty Nineteen: Consider adding additional social media icons

Reported by: kjellr Owned by:
Milestone: Awaiting Review Priority: low
Severity: normal Version: 5.0.3
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:
PR Number:

Description

There have been a handful of requests for additional icons to be added to the social media links iconset in Twenty Nineteen:

Wikipedia and Discord have working patches already (attached):

https://cldup.com/e-JpiWU-h9-3000x3000.png

Twenty Seventeen has a similar social media iconset included, and has received similar requests: #43342, #45328

I don't see an issue with adding these ones (especially the ones that have patches already), but I will note that we should probably agree on some limitations around these sorts of additions: there are a near-infinite number of social media services out there, and we won't be able to include them all. In addition, each icon added provides a (admittedly very tiny) file size bump, and as these services update their logos over time, there'll be maintenance required to keep these up to date.

Here is the current list of supported icons in Twenty Nineteen, for reference:
https://codex.wordpress.org/Twenty_Nineteen#Add_Social_Icons

Attachments (2)

45943-discord.patch (2.4 KB) - added by kjellr 9 months ago.
45943-wikipedia.patch (6.0 KB) - added by kjellr 9 months ago.

Download all attachments as: .zip

Change History (4)

#1 @silas2209
9 months ago

I think a Discord or Mastodon logo would be nice, but I don't really understand the need for a Wikipedia icon. I don't think anyone wants to link a Wikipedia article in a menu.

#2 @klaas1
9 months ago

@silas2209 I want to link to the corresponding wikipedia article [person or club for example]

Note: See TracTickets for help on using tickets.