Make WordPress Core

Opened 6 years ago

Last modified 4 months ago

#45948 new defect (bug)

WSOD protection message formatted incorrectly on windows

Reported by: pbiron's profile pbiron Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bootstrap/Load Keywords: reporter-feedback
Focuses: Cc:

Description

When the WSOD protection in 5.1 beta1 pauses a plugin on a windows host, the message that displays in wp-admin/plugins.php the file path where the error occurred doesn't display properly (the path separator has been stripped). See the attached screenshot.

Attachments (1)

wsod_message.png (14.8 KB) - added by pbiron 6 years ago.

Download all attachments as: .zip

Change History (5)

@pbiron
6 years ago

#1 @pbiron
6 years ago

There are probably a few places this could be fixed, in the few minutes I've looked through this new code I think easiest would be in wp_record_extension_error().

That function already calls wp_normalize_path( $error['file'] ). I think it should actually set $error['file'] to the return value of that call to wp_normalize_path()...but I'll leave to those who know this new code better than I to decide (unless folks want me to do a patch for that fix).

#2 @jorbin
4 months ago

  • Keywords reporter-feedback added

I don't have a Windows machine, can someone confirm if this is still an issue and if so, provide a patch with screenshots please.

#3 @pbiron
4 months ago

@jorbin I'll try to "force" a WSOD on my Win machine tomorrow (don't have time today) and post an update here as to whether the problem still exists.

#4 @jorbin
4 months ago

Thanks! If it helps, https://wordpress.org/plugins/this-plugin-should-not-be-used/ is a plugin that contains an error. Version 0.1 is fine and version 0.2 will white screen.

Note: See TracTickets for help on using tickets.