Twenty Nineteen: Fix social media icons to use the correct height & width attribute

[crunnells]

This comes from a PR in GitHub: ​https://github.com/WordPress/twentynineteen/pull/754

The PR in question proposes to change social icon sizes to 26px, because of what _seems_ to be an erroneous setting in twentynineteen_nav_menu_social_icons(). I suggest removing the 26, since the CSS is set to show the icons at 32px, which overrides the 26px _anyway_.

Maybe update the default from 24 to 32 as well?

[mukesh27]

@crunnells Yes theme use css of 32 height and width of SVG icon and icon render 26 social and link icon with 24.

[laurelfulford]

Thanks @mukesh27 and @crunnells!

Just to make sure: @allancole or @kjellr, was the smaller size (24 or 26) meant to override anything in the social menu? As Chris pointed out, the CSS is setting the actual size (32); I agree that switching it to 32 in the code as well makes sense if that's the intended display size. I just want to make sure I'm not missing something here - thanks!

[laurelfulford]

Got confirmation that this can be switched to 32 in twentynineteen_nav_menu_social_icons(), so the code matches how the icons actually display.

[tahmidulkarim]

I have changed it to 32. Patch attached.

I updated the instances of svg icons in icon-functions.php to 26px from 24px.

Trac ticket: https://core.trac.wordpress.org/ticket/45950

I updated the instances of svg icons in icon-functions.php to 26px from 24px.

Trac ticket: https://core.trac.wordpress.org/ticket/45950