WordPress.org

Make WordPress Core

Opened 10 days ago

Last modified 10 days ago

#45950 new defect (bug)

Twenty Nineteen: Fix social media icons to use the correct height & width attribute

Reported by: crunnells Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.0.3
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

This comes from a PR in GitHub: https://github.com/WordPress/twentynineteen/pull/754

The PR in question proposes to change social icon sizes to 26px, because of what _seems_ to be an erroneous setting in twentynineteen_nav_menu_social_icons(). I suggest removing the 26, since the CSS is set to show the icons at 32px, which overrides the 26px _anyway_.

Maybe update the default from 24 to 32 as well?

Attachments (2)

24px SVG icon.png (45.9 KB) - added by mukesh27 10 days ago.
32px SVG icon.png (46.8 KB) - added by mukesh27 10 days ago.

Download all attachments as: .zip

Change History (4)

#1 @mukesh27
10 days ago

@crunnells Yes theme use css of 32 height and width of SVG icon and icon render 26 social and link icon with 24.

#2 @mukesh27
10 days ago

  • Component changed from General to Bundled Theme
Note: See TracTickets for help on using tickets.